fix(github-format): preserve path#1748
Conversation
reubenwong97
force-pushed
the
fix/missing-path
branch
from
e34c981 to
256a3be
Compare
|
Hi @woodruffw , Can you help to take a look at this? Thanks! |
| // gracefully. | ||
| let filepath = primary.symbolic.key.sarif_path(); | ||
| let filepath = Utf8Path::new(primary.symbolic.key.presentation_path()); | ||
| let filepath = filepath.strip_prefix(".").unwrap_or(filepath); |
There was a problem hiding this comment.
Perhaps this should be moved to a higher level so that plain does not have the same issues:
🌈 zizmor v1.23.1
INFO audit: zizmor: 🌈 completed ./.github/workflows/ci.yml
warning[excessive-permissions]: overly broad permissions
--> ./.github/workflows/ci.yml:9:3
There was a problem hiding this comment.
Thanks for the suggestion!
@woodruffw should we go ahead with this? If so would it be an amendment to the behavior of presentation_path?
|
Hi @woodruffw , Could you take a look at the discussion here when you have some time? Thanks! |
|
Yeah, I'll try and get to this in the next day or so. |
|
I think it should also be fixed for Here I run zizmor twice with 
|
|
Thanks @crazy-max , this makes sense to me. I'll prepare a change and get @woodruffw 's input. |
4 participants
Pre-submission checks
Please check these boxes:
Mandatory: This PR corresponds to an issue [BUG]: Part of the path is missing when displayed in
GitHubformat #1745 .Having read the AI policy, I hereby disclose the use of an LLM or other
AI coding assistant in the creation of this PR. PRs will not be rejected
for using AI tools, but will be rejected for undisclosed use or
use that violates the policy.
If a checkbox is not applicable, you can leave it unchecked.
Summary
For the github format, uses the presentation path with prefix stripping instead of the sarif path.
Test Plan
Added snapshot integration tests for the scenarios described in the issue.
Closes #1745