Skip to content

[BUG]: Ignore comment placement is not intuitive #612

@moe-ad

Description

@moe-ad

Pre-submission checks

  • I am not filing a feature request. These should be filed via the feature request form instead.
  • I have looked through the open issues for a duplicate report.

Expected behavior

Ignore results within composite actions using inline comments.

Actual behavior

Results are not ignored when inline comments are used within composite actions.

Reproduction steps

On a composite action that raises error[template-injection] for example, adding # zizmor: ignore[template-injection] has no effect.

Logs


Additional context

Kudos for the great work being done @woodruffw.

zizmor is being used to tighten up our actions here: ansys/actions#725

Note

I am opening this as a bug and not as a feature request because the documentation implies that inline comments should be supported within composite actions. Although on this page, it is stated that a zizmor.yml config cannot be used. I stand to be corrected though, maybe I missed something. Thanks!

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions