Skip to content

Feature: don't raise concurrency-limits error if cancel-in-progress is set #1302

@marcoieni

Description

@marcoieni

Pre-submission checks

  • I am not reporting a bug (crash, false positive/negative, etc). These must be filed via the bug report template.
  • I have looked through both the open and closed issues for a duplicate request.

What's the problem this feature will solve?

I have some jobs where I need

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: false

e.g. a CD pipeline that releases the artifacts on tags.

However, zizmor raises the error:

help[concurrency-limits]: insufficient job-level concurrency limits
  --> ./.github/workflows/cd.yml:18:1
   |
18 | / concurrency:
19 | |   group: ${{ github.workflow }}-${{ github.ref }}
20 | |   cancel-in-progress: false
   | |___________________________^ cancel-in-progress set to false

Describe the solution you'd like

Imo if cancel-in-progress is set, this lint shouldn't be raised, similar to how artipacked isn't raised if persist-credentials is set.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions