Repository navigation
Commit 90cf7be
authored
Revert: [web] Keep the keyboard up during an iOS caret drag (flutter#190926)
Reverts: [[web] Keep the keyboard up during an iOS caret
drag](flutter#190014)
Initiated by: @jtmcdole
Reason for reverting:
Original PR Author: @flutter-zl
Reviewed By: @Renzo-Olivares
The original PR description is provided below:
Fixes flutter#189744
**Problem**
On iOS 27, long-press-dragging the selection caret in a Web TextField
dismisses the keyboard mid-gesture. WebKit transiently blurs the hidden
input with a null relatedTarget while the document keeps focus, then
refocuses it a frame later,and the engine reacted to that blink on two
listeners that each tore the input down. A plain input ignores the same
blur, so the cause is Flutter's reaction, not a WebKit limitation.
**Fix**
On iOS both listeners now defer their teardown by 100ms and cancel it if
the input refocuses, mirroring the existing flutter#155265 deferred close. Done
and tap-away never refocus so they still close, and the deferral is
narrowed to the exact drag signature so every other focus transition is
unaffected.
**Demo**
Before: https://flutter-demo-52-before.web.app (keyboard dismisses mid
caret drag)
After: https://flutter-demo-52-after.web.app (keyboard stays up)
Repro on iOS 27 Safari: tap the field to raise the keyboard, then
long-press and drag the selection caret. Before dismisses; after stays
up. Done and tap-away still dismiss.1 parent b05fabd commit 90cf7be
4 files changed
Lines changed: 2 additions & 396 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine
- platform_dispatcher
- text_editing
- test/engine
- platform_dispatcher
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | 11 | | |
18 | 12 | | |
19 | 13 | | |
| |||
26 | 20 | | |
27 | 21 | | |
28 | 22 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | 23 | | |
45 | 24 | | |
46 | 25 | | |
| |||
57 | 36 | | |
58 | 37 | | |
59 | 38 | | |
60 | | - | |
61 | 39 | | |
62 | 40 | | |
63 | 41 | | |
| |||
76 | 54 | | |
77 | 55 | | |
78 | 56 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | 57 | | |
83 | 58 | | |
84 | 59 | | |
| |||
95 | 70 | | |
96 | 71 | | |
97 | 72 | | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
| 73 | + | |
123 | 74 | | |
124 | 75 | | |
125 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
51 | 50 | | |
52 | 51 | | |
53 | 52 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | 53 | | |
67 | 54 | | |
68 | 55 | | |
| |||
1875 | 1862 | | |
1876 | 1863 | | |
1877 | 1864 | | |
1878 | | - | |
| 1865 | + | |
1879 | 1866 | | |
1880 | 1867 | | |
1881 | 1868 | | |
| |||
1884 | 1871 | | |
1885 | 1872 | | |
1886 | 1873 | | |
1887 | | - | |
1888 | | - | |
1889 | | - | |
1890 | | - | |
1891 | | - | |
1892 | | - | |
1893 | | - | |
1894 | | - | |
1895 | | - | |
1896 | | - | |
1897 | | - | |
1898 | | - | |
1899 | | - | |
1900 | | - | |
1901 | | - | |
1902 | | - | |
1903 | | - | |
1904 | | - | |
1905 | | - | |
1906 | | - | |
1907 | | - | |
1908 | | - | |
1909 | | - | |
1910 | | - | |
1911 | | - | |
1912 | | - | |
1913 | 1874 | | |
1914 | 1875 | | |
1915 | 1876 | | |
| |||
2793 | 2754 | | |
2794 | 2755 | | |
2795 | 2756 | | |
2796 | | - | |
2797 | | - | |
2798 | | - | |
2799 | | - | |
2800 | | - | |
2801 | | - | |
2802 | | - | |
2803 | | - | |
2804 | | - | |
2805 | | - | |
2806 | 2757 | | |
2807 | 2758 | | |
2808 | 2759 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
| |||
269 | 268 | | |
270 | 269 | | |
271 | 270 | | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
358 | | - | |
359 | | - | |
360 | | - | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
377 | | - | |
378 | | - | |
379 | | - | |
380 | | - | |
381 | | - | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | 271 | | |
423 | 272 | | |
424 | 273 | | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | 274 | | |
444 | 275 | | |
445 | 276 | | |
| |||
0 commit comments