lib/std/posix/test.zig: enable disabled tests using CWD#22945
Merged
alexrp merged 1 commit intoziglang:masterfrom Feb 20, 2025
Merged
lib/std/posix/test.zig: enable disabled tests using CWD#22945alexrp merged 1 commit intoziglang:masterfrom
alexrp merged 1 commit intoziglang:masterfrom
Conversation
Four tests in lib/std/posix/test.zig were disabled because they created fixed-name files in the current working directory, and this caused problems if tests were running in parallel with other build's tests. This PR fixes those tests to all use `std.testing.tmpDir` to create unique temporary names and directories. Also clean the tests up to more consistently use `defer` to clean up, or to just rely on tmpDir cleanup to remove individual files. Working on these tests revealed a bunch of stale WASI code paths in posix.zig, fixed by replacing stale `wast.AT.FDCWD` references with just `AT.FDCWD`. Fixes ziglang#14968.
alexrp
approved these changes
Feb 20, 2025
Member
|
Seems reasonable to me, but will let @squeek502 check the WASI bits and merge. |
squeek502
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four tests in lib/std/posix/test.zig were disabled because they created fixed-name files in the current working directory, and this caused problems if tests were running in parallel with other build's tests.
This PR fixes those tests to all use
std.testing.tmpDirto create unique temporary names and directories.Also clean the tests up to more consistently use
deferto clean up, or to just rely on tmpDir cleanup to remove individual files.Working on these tests revealed a bunch of stale WASI code paths in posix.zig, fixed by replacing stale
wast.AT.FDCWDreferences with justAT.FDCWD.Fixes #14968.