Read System.keychain as well as SystemRootCertificates.keychain for MacOS CA Bundle#22701
Read System.keychain as well as SystemRootCertificates.keychain for MacOS CA Bundle#22701alexrp merged 1 commit intoziglang:masterfrom dreilly1982:master
Conversation
|
@FnControlOption would you mind reviewing this since you contributed #14325? |
|
Ran Amended the commit for a cleaner diff: FnControlOption@e2bbdee |
|
I appreciate you cleaning up the diff on that one, I didn't realize just how ugly that looked until the PR was already made. As far as CA Bundles on MacOS are concerned, I think it should eventually read off of any keychain the user has loaded, and I have code that can pull those, but that requires linking against the MacOS frameworks, and I'm not familiar enough with the zig build system (yet) to do that in this context, nor do I know if that is a good idea. |
|
Is it intentional that both keychain files are required after these changes (i.e. if either one can't be read, the function fails)? |
|
@squeek502 possibly related: #22870 |
This adds
/Library/Keychains/System.keychainas a keychain to look for trusted CA certficates. Fixes #22700