Skip to content

x86_64+macho: pass more behavior tests#18735

Merged
kubkon merged 1 commit intomasterfrom
x86_64-macho-tests
Feb 6, 2024
Merged

x86_64+macho: pass more behavior tests#18735
kubkon merged 1 commit intomasterfrom
x86_64-macho-tests

Conversation

@kubkon
Copy link
Member

@kubkon kubkon commented Jan 29, 2024

Fixes #17646

@kubkon kubkon force-pushed the x86_64-macho-tests branch from c555b76 to 4e2d80d Compare January 29, 2024 20:23
@kubkon kubkon marked this pull request as ready for review January 29, 2024 20:24
@kubkon
Copy link
Member Author

kubkon commented Jan 29, 2024

I've noticed in the previous run that x86_64-macos CI crashed during @bitReverse test. This is interesting since it works fine for me locally but I'm on macOS 13 whereas our CI is running on macOS 11. If it fails again, I'll try reproing it locally on macOS 11, and extract an issue for the future.

@kubkon
Copy link
Member Author

kubkon commented Jan 29, 2024

Just pre-emptively tested if I can repro a crash locally on my x86_64 macOS 11 VM but no dice, everything passed.

@kubkon kubkon force-pushed the x86_64-macho-tests branch from f0cd6d5 to ec13dd1 Compare February 6, 2024 10:29
@kubkon kubkon enabled auto-merge (rebase) February 6, 2024 15:25
@kubkon kubkon merged commit 52066bf into master Feb 6, 2024
@kubkon kubkon deleted the x86_64-macho-tests branch February 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some x86 backend behavior tests are disabled for macho

1 participant