Skip to content

allow passing by non-copying value#1109

Merged
andrewrk merged 3 commits intomasterfrom
pass-by-non-copying-value
Jun 17, 2018
Merged

allow passing by non-copying value#1109
andrewrk merged 3 commits intomasterfrom
pass-by-non-copying-value

Conversation

@andrewrk
Copy link
Member

@andrewrk andrewrk commented Jun 14, 2018 •
edited
Loading

closes #733

Here's the new thing you're allowed to do:

test "pass by non-copying value" {
    assert(bar(Point{ .x = 1, .y = 2 }) == 3);
}

const Point = struct {
    x: i32,
    y: i32,
};

fn bar(pt: Point) i32 {
    return pt.x + pt.y;
}

See #733 (comment)

All the old code still works, but it is now un-idiomatic when one would be better using these semantics.

And then the breaking change will come when we remove the implicit cast from T to *const T.

@andrewrk andrewrk force-pushed the pass-by-non-copying-value branch 2 times, most recently from 87b27a9 to 66f5f77 Compare June 14, 2018 03:18
@andrewrk andrewrk force-pushed the pass-by-non-copying-value branch from a02d2b5 to 9929426 Compare June 16, 2018 23:15
@andrewrk andrewrk force-pushed the pass-by-non-copying-value branch from 2c6a921 to 472b7ef Compare June 16, 2018 23:37
@andrewrk andrewrk merged commit 7515187 into master Jun 17, 2018
@andrewrk andrewrk deleted the pass-by-non-copying-value branch June 17, 2018 01:13
@Hejsil Hejsil mentioned this pull request Jun 18, 2018
Closed
@tgschultz tgschultz mentioned this pull request Aug 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add another way of passing non-copyable things as parameters

2 participants

@andrewrk @bnoordhuis