Repository navigation
bench: harden and extend the parquet_row_filter_skip suite - #3
Merged
zhuqi-lucas merged 1 commit intoAug 14, 2026
Conversation
- Remove the invalid top-level 'name' key from the .suite file: RawSuite is #[serde(deny_unknown_fields)] and discover_suites propagates the parse error, so benchmark_runner failed for every suite, not just this one (bench.sh drives 'cargo bench --bench sql' directly and never parses .suite files, which is why runs through bench.sh still worked). Declare the PRED_ROWS/RG_SIZE knobs as suite options while there, so benchmark_runner exposes --rows/--rg-size. - Make the clustering invariant explicit: add ORDER BY to the COPY so the file is guaranteed to be written in key order instead of relying on the physical planner never repartitioning the generate_series scan. - Strengthen the asserts: exact row count, exact matching-row count (also a correctness canary for the skip itself), and a check that pushdown_filters actually took effect so config drift cannot silently turn the suite into a no-op. Settings move from the load script to an init script, matching the clickbench suites. - Add coverage beyond the single best-case query: skip/q02 (predicate matches everything, all row groups fully matched), skip/q03 (filter column projected, so the skip cannot avoid decoding it), and a control subgroup on a scrambled key where no row group is ever fully matched, measuring the overhead of the check when it cannot fire. - Document the suite and the RG_SIZE knob in sql_benchmarks/README.md. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01S1i7A2gz58sXRWiDyk9ijj
Author
|
cc @zhuqi-lucas |
zhuqi-lucas
merged commit Aug 14, 2026
811dfb0
into
zhuqi-lucas:bench/parquet-row-filter-skip
16 checks passed
Owner
|
Thank you @adriangb , merged your suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the invalid top-level 'name' key from the .suite file: RawSuite is #[serde(deny_unknown_fields)] and discover_suites propagates the parse error, so benchmark_runner failed for every suite, not just this one (bench.sh drives 'cargo bench --bench sql' directly and never parses .suite files, which is why runs through bench.sh still worked). Declare the PRED_ROWS/RG_SIZE knobs as suite options while there, so benchmark_runner exposes --rows/--rg-size.
Make the clustering invariant explicit: add ORDER BY to the COPY so the file is guaranteed to be written in key order instead of relying on the physical planner never repartitioning the generate_series scan.
Strengthen the asserts: exact row count, exact matching-row count (also a correctness canary for the skip itself), and a check that pushdown_filters actually took effect so config drift cannot silently turn the suite into a no-op. Settings move from the load script to an init script, matching the clickbench suites.
Add coverage beyond the single best-case query: skip/q02 (predicate matches everything, all row groups fully matched), skip/q03 (filter column projected, so the skip cannot avoid decoding it), and a control subgroup on a scrambled key where no row group is ever fully matched, measuring the overhead of the check when it cannot fire.
Document the suite and the RG_SIZE knob in sql_benchmarks/README.md.
Claude-Session: https://claude.ai/code/session_01S1i7A2gz58sXRWiDyk9ijj
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?