Repository navigation
Commit fc15e25
authored
refactor(parquet): extract InitialDecoderState from the opener decoder-setup block (apache#24572)
## Which issue does this PR close?
- Closes apache#24286.
## Rationale for this change
Split out from apache#23696 (per @adriangb's [decomposition
proposal](apache#23696 (comment)),
PR 3).
The decoder-setup block in the opener returns a bare `(decoder, rg_plan,
has_row_selection)` tuple. Giving it a named `InitialDecoderState`
struct keeps the values carried out of the block self-documenting, and
means the follow-up feature PR (apache#23696) adds fields to a named struct
instead of reshaping a positional tuple.
## What changes are included in this PR?
- `push_decoder.rs`: new `pub(crate) struct InitialDecoderState {
decoder, rg_plan, has_row_selection }`.
- `opener/mod.rs`: the decoder-setup block returns `InitialDecoderState
{ .. }` and is destructured back into the same locals.
Pure refactor, no behavior change.
## Are these changes tested?
Covered by the existing `dynamic_row_group_pruning` integration tests
(they drive the opener path); all pass. `clippy --all-targets
--all-features -D warnings` is clean.
## Are there any user-facing changes?
No.1 parent 933710d commit fc15e25
2 files changed
Lines changed: 27 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
1458 | 1459 | | |
1459 | 1460 | | |
1460 | 1461 | | |
1461 | | - | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
1462 | 1467 | | |
1463 | 1468 | | |
1464 | 1469 | | |
| |||
1520 | 1525 | | |
1521 | 1526 | | |
1522 | 1527 | | |
1523 | | - | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
1524 | 1533 | | |
1525 | 1534 | | |
1526 | 1535 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
120 | 135 | | |
121 | 136 | | |
122 | 137 | | |
| |||
0 commit comments