Skip to content

Commit 9641904

Browse files
committed
test: disable page index in apache#24352 q26 test so the dynamic pruner still fires
topk_pushdown_does_not_reread_delivered_row_group asserts the runtime pruner fires (row_groups_pruned_dynamic_filter >= 1). With page index on, the `search_phrase <> ''` filter produces an intra-RG RowSelection, and this PR disables the runtime pruner whenever a selection is present — so the test's q26 scenario no longer exercised the pruner and failed. Bug apache#24352 is row-filter-driven and does not need the page index, so disable page-index reading for this test to keep it exercising the rg_plan-sync path.
1 parent 1370d2b commit 9641904

1 file changed

Lines changed: 14 additions & 4 deletions

File tree

‎datafusion/core/tests/parquet/dynamic_row_group_pruning.rs‎

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ use std::sync::Arc;
3535
use arrow::array::{ArrayRef, Int64Array, RecordBatch, StringArray};
3636
use arrow_schema::{DataType, Field, Schema};
3737

38+
use datafusion::prelude::SessionConfig;
39+
3840
use crate::parquet::Unit::RowGroup;
3941
use crate::parquet::{ContextWithParquet, Scenario};
4042

@@ -655,12 +657,20 @@ async fn topk_pushdown_does_not_reread_delivered_row_group() {
655657

656658
// `RowGroup(2048)` writes one row group per 2048-row batch (4 RGs) and
657659
// enables `pushdown_filters`, required for the dynamic filter to reach the
658-
// parquet scan.
659-
let mut ctx = ContextWithParquet::with_custom_data(
660+
// parquet scan. Page-index reading is disabled: this test exercises the
661+
// #24352 empty-row-group / rg_plan-sync path, which is row-filter-driven and
662+
// does not need the page index. With the page index on, `search_phrase <> ''`
663+
// produces an intra-row-group `RowSelection`, and #24355 disables the runtime
664+
// pruner whenever a row selection is present — which would stop this test
665+
// from exercising the dynamic pruner at all.
666+
let mut config = SessionConfig::new();
667+
config.options_mut().execution.parquet.enable_page_index = false;
668+
let mut ctx = ContextWithParquet::with_config(
660669
Scenario::Int,
661670
RowGroup(2048),
662-
Arc::clone(&schema),
663-
batches,
671+
config,
672+
Some(Arc::clone(&schema)),
673+
Some(batches),
664674
)
665675
.await;
666676

0 commit comments

Comments
 (0)