Skip to content

fix(app): ignore none-only reasoning variants in tooltip - #1

Merged
zhengkaics merged 2 commits into
zhengkaics:model-reasoning-capability-v2from
Furox-Art:fix/55100-none-only-followup
Oct 17, 2026
Merged

fix(app): ignore none-only reasoning variants in tooltip#1
zhengkaics merged 2 commits into
zhengkaics:model-reasoning-capability-v2from
Furox-Art:fix/55100-none-only-followup

Conversation

@Furox-Art

@Furox-Art Furox-Art commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Fixes anomalyco#53520 (together with the parent PR anomalyco#55100). Also related: anomalyco#50257.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This PR targets the head branch of anomalyco#55100, not OpenCode dev.

The reasoning tooltip fallback introduced by anomalyco#55100 treats every nonempty variants array as proof of reasoning support. An array containing only none instead represents the ability to disable reasoning; it should not report "Reasoning supported".

Replace model.variants.length > 0 with model.variants.some((variant) => variant.id !== "none"). Preserve the catalog's explicit reasoning flag and the existing reasoningField fallback. Add regression fixtures for none alone and none + high.

How did you verify your code works?

Screenshots / recordings

Not applicable to this metadata-only refinement; no patched desktop build available. Test cases demonstrate the changed tooltip value.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented Oct 16, 2026

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@Furox-Art Furox-Art mentioned this pull request Oct 16, 2026
Closed
3 of 6 tasks
@Furox-Art ChatGPT Codex Connector

Furox-Art commented Oct 16, 2026

Copy link
Copy Markdown
Author

@zhengkaics A GitHub Actions policy edge case is blocking the needs:issue label on this stacked PR, despite linking the existing upstream issue.

I checked the inherited .github/workflows/pr-standards.yml: it requires pullRequest.closingIssuesReferences.totalCount > 0. GitHub does not create closing-issue links for PRs targeting non-default branches (this PR correctly targets your model-reasoning-capability-v2 branch rather than dev), regardless of the Fixes anomalyco/opencode#53520 reference. Your fork also has Issues disabled. See GitHub's documentation.

So this is a workflow-rule mismatch, not an unreported bug. Please merge the 2-file stacked PR into your feature branch (or cherry-pick dc8e693c and f47cec3f) to include the independently tested none-only regression fix. If the label/check blocks merging, it needs a maintainer-side exemption for stacked, non-default-branch PRs; I cannot change your fork's settings or workflow.

Verification: original 4/5 tests, corrected 5/5, only two files changed, and GitHub shows this PR as mergeable.

@zhengkaics
zhengkaics merged commit 029af99 into zhengkaics:model-reasoning-capability-v2 Oct 17, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs:issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Furox-Art @zhengkaics