Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses PHP 8 compatibility warnings by adding an isset() check before accessing $_POST['hlist']. The PR title mentions fixing both "PHP 8 compatibility warnings" and "Header redirect issues," though only the PHP 8 compatibility fix is visible in the provided diff.
Changes:
- Added
isset()check before accessing$_POST['hlist']to prevent undefined array key warnings in PHP 8
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| $plist = trim($_POST['hlist']); | ||
| if(isset($_POST['hlist']))$plist = trim($_POST['hlist']); |
There was a problem hiding this comment.
Missing space between the condition and the statement. The syntax should be if(isset($_POST['hlist'])) $plist = trim($_POST['hlist']); with a space after the closing parenthesis. This deviates from the established convention in the codebase, as seen in trunk/web/admin/contest_list.php:31 and trunk/web/admin/news_list.php:31 where similar one-line if statements use a space.
No description provided.