Repository navigation
fix: find the git sub-command after global options in read-only mode - #3357
Merged
Merged
Conversation
In read-only mode, `git -C dir status` and `git -c k=v log` were refused because the value of the global option was taken as the sub-command. Skip git's leading global options first, and stop treating -c/-C as write flags of every sub-command (only `git branch` uses them to copy a branch).
Owner
|
Merged — thanks for your first contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3355.
In read-only mode,
_check_git_read_only()took the first non-dash argument as the git sub-command, sogit -C <dir> statusorgit -c k=v logwas refused with a message naming the path or value. It now skips git's leading global options, including the ones that take a value, before finding the sub-command.-cand-Cwere also in the shared write-flag list, which would have deniedgit -c ... log, so they are now treated as write flags only forgit branch.What does this PR do?
See above.
Type of change
Checklist