This repository was archived by the owner on Dec 2, 2025. It is now read-only.
Adding unshare back to fix hang issue#23
Merged
zhaarey merged 1 commit intozhaarey:arm64from Apr 17, 2025
Nirzak:patch-1
Merged
Adding unshare back to fix hang issue#23zhaarey merged 1 commit intozhaarey:arm64from Nirzak:patch-1
zhaarey merged 1 commit intozhaarey:arm64from
Nirzak:patch-1
Conversation
wrapper arm version is highly dependent on the child parent process structure. so without unshare the child process may never exit causing the hang issue.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrapper arm64 version is highly dependent on the child parent process structure. so without unshare the child process may never exit which willl cause the hang issue. If we really want to remove the unshare then we have to implement proper daemonization and child reaping logics on the code. Since then it can't be safely removed.