Repository navigation
Commit b08d70e
authored
Fixes apache#23080 (partial)
## Summary
Removes `datafusion_catalog_listing::helpers::split_files`, deprecated
since 47.0.0 in favor of the `FileGroup::split_files` method on
`datafusion-catalog/datasource::file_groups::FileGroup`.
Verified workspace-wide:
- 0 non-test call sites for the deprecated free function (`grep -rn
"split_files" --include="*.rs"`)
- The 5 in-tree references in
`datafusion/catalog-listing/src/helpers.rs::tests::test_split_files` are
calls on `FileGroup` values (`files.clone().split_files(N)`), not the
deprecated free function — they exercise `FileGroup::split_files`
correctly.
- 3 other call sites in `datafusion/catalog-listing/src/table.rs` also
call the `FileGroup` method.
- `cargo check -p datafusion-catalog-listing` is clean (no warnings
after also dropping the now-unused `use std::mem;`).
- `cargo test -p datafusion-catalog-listing test_split_files` passes.
This is a 36-line pure deletion: 35 lines for the function body plus the
`use std::mem;` import. Replaces only — the public method
`FileGroup::split_files` already exists at
`datafusion/datasource/src/file_groups.rs:454` and is what callers use.
## Test plan
- `cargo check -p datafusion-catalog-listing` ✓ (clean)
- `cargo test -p datafusion-catalog-listing test_split_files` ✓ 1 passed
- `grep -rn "helpers::split_files\|use.*helpers::{.*split_files"
datafusion/` → 0 matches after this change
`(e of in-tree call sites verified before edit via workspace grep;
revisited after edit.)`
## AI assistance
This patch was drafted with the help of an AI coding assistant. The diff
was reviewed line by line before submission and the change was verified
independently (cargo check + a focused cargo test run).
Signed-off-by: Dodothereal
<[email protected]>
Signed-off-by: Dodothereal <[email protected]>
1 parent e2c3e18 commit b08d70e
1 file changed
Lines changed: 0 additions & 36 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
137 | 136 | | |
138 | 137 | | |
139 | 138 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | 139 | | |
176 | 140 | | |
177 | 141 | | |
| |||
0 commit comments