Repository navigation
Commit 30d944c
authored
chore(datasource): remove deprecated
## Summary
Removes the free function `datafusion_datasource::write::create_writer`,
which was deprecated in 48.0.0 with the suggestion to use
`ObjectWriterBuilder::new(...)` instead. Per the [API health deprecation
guidelines](https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines),
APIs deprecated in 48.0.0 or earlier are now eligible for removal.
A grep across the workspace confirms `create_writer` has **zero
callers** anywhere in the repo (the other matches are differently-named
methods `create_writer_physical_plan` and `create_writer_props`, which
we are not touching) and is not re-exported from
`datafusion_datasource::lib`. This is the smallest possible pure-removal
cleanup — 16 lines deleted from a single file.
Part of apache#23080 (partial — one of the listed eligible items).
## Test plan
```
git diff upstream/main..chore/remove-deprecated-create-writer
datafusion/datasource/src/write/mod.rs | 16 ----------------
1 file changed, 16 deletions(-)
```
Since all callers are gone, no test updates are needed; the standard CI
matrix (`./dev/rust_lint.sh`, `cargo check -p datafusion-datasource`,
downstream consumer builds) will catch any indirect breakage.
## AI assistance
Used an AI coding assistant to identify and minimally remove the unused
deprecated function. I read the file end-to-end before and after the
diff, verified zero callers via a workspace grep, and the change is a
16-line pure deletion.create_writer free function (Closes apache#23080 — partial) (apache#23129)1 parent e7349e5 commit 30d944c
1 file changed
Lines changed: 0 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | 78 | | |
95 | 79 | | |
96 | 80 | | |
| |||
0 commit comments