add window.ZeroMdCssUrls hook for default CSS#12
Closed
bennypowers wants to merge 1 commit intozerodevx:masterfrom
Closed
add window.ZeroMdCssUrls hook for default CSS#12bennypowers wants to merge 1 commit intozerodevx:masterfrom
bennypowers wants to merge 1 commit intozerodevx:masterfrom
Conversation
Owner
|
Thanks for the PR! Agree that some mechanism should be exposed to allow global settings. Let me take a look and get back to you. |
Owner
|
@bennypowers Thanks again for the PR - I thought it makes sense to expose all configurations (not just This also gives the opportunity to refactor Hopefully this fits your requirements! |
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
There's no current way to set a default theme. You end up having to copy/paste
css-urls="['my-theme.css']"in to every instance of the elementProposed Solution
Expose an optional
ZeroMdCssUrlshook on the window objectSome Possible Objections
Pollutes
window, but then again, there's already ZeroMdStoreAlternative Solutions
default to a shipped file, (i.e. 'zero-md/defualt-theme.css') tell users to overwrite that file