drivers: ethernet: stm32: Disable HW checksums by default

icsys-omh · carlescufi · commit 80bfed3b4484 · 2023-05-22T15:25:29.000+02:00
Without this change, there's a difference between what the V2 Ethernet HAL claims to be its capabilities in eth_stm32_hal_get_capabilities() and what is actually enabled when CONFIG_ETH_STM32_HW_CHECKSUM is disabled. This difference somehow causes the checksum in outgoing packets to become 0, and hence seems to break networking at least on some PHYs. This commit disables HW checksums by default even when V2 driver is in use, and this hence fixes networking when CONFIG_ETH_STM32_HW_CHECKSUM is disabled. This fixes #57629. Signed-off-by: Ole Morten Haaland <omh@icsys.no>
diff --git a/drivers/ethernet/eth_stm32_hal.c b/drivers/ethernet/eth_stm32_hal.c
@@ -1203,7 +1203,8 @@ static int eth_initialize(const struct device *dev)
 	memset(&tx_config, 0, sizeof(ETH_TxPacketConfig));
 	tx_config.Attributes = ETH_TX_PACKETS_FEATURES_CSUM |
 				ETH_TX_PACKETS_FEATURES_CRCPAD;
-	tx_config.ChecksumCtrl = ETH_CHECKSUM_IPHDR_PAYLOAD_INSERT_PHDR_CALC;
+	tx_config.ChecksumCtrl = IS_ENABLED(CONFIG_ETH_STM32_HW_CHECKSUM) ?
+			ETH_CHECKSUM_IPHDR_PAYLOAD_INSERT_PHDR_CALC : ETH_CHECKSUM_DISABLE;
 	tx_config.CRCPadCtrl = ETH_CRC_PAD_INSERT;
 #endif /* CONFIG_SOC_SERIES_STM32H7X || CONFIG_ETH_STM32_HAL_API_V2 */
 
