chore: Added sidebar minimize button to Zenn CLI preview#151
Merged
catnose99 merged 1 commit intozenn-dev:masterfrom Jun 3, 2021
Merged
chore: Added sidebar minimize button to Zenn CLI preview#151catnose99 merged 1 commit intozenn-dev:masterfrom
catnose99 merged 1 commit intozenn-dev:masterfrom
Conversation
catnose99
approved these changes
Jun 3, 2021
Contributor
catnose99
left a comment
catnose99
left a comment
There was a problem hiding this comment.
素晴らしいPRをありがとうございます！
配慮いただき感謝です。zenn-cliを刷新する際にはこの部分を含めて書き直すことになるかもしれませんが、ご理解いただけると幸いです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#141
1画面で執筆している場合には Zenn CLI のプレビューでサイドバーを非表示にできると執筆体験が向上すると思いましたのでPRさせていただきました。
なるべく既存コードを変更しない様に表示/非表示のトグルボタンを設置しております。
別のPRで下記の様に記載されていましたが、問題ない様でしたらご確認いただければ幸いです。