Repository navigation
Support Node.js 24 in TypeScript packages - #1183
Merged
Merged
Conversation
strickvl
self-requested a review
September 24, 2026 15:45
strickvl
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
.node-versionand@types/nodeon Node 22 so Node 22 remains the build and type-definition floor.Why?
Node 24 was omitted from the supported TypeScript runtimes. The packages and examples pass the existing validation lane on Node 24 without requiring runtime code changes.
Closes #1144.
Release context
The three TypeScript packages continue to version and release together. This changes engine metadata and compatibility coverage only; it does not change dependencies or the lockfile.
Reviewer Notes
The supported range remains deliberately explicit: Node 22.22+, Node 24, and Node 26. The new CI job runs the same service-free package validation used for Node 26 at both the Node 24 floor (
24.0.0) and the current24.xrelease. Node 22 stays pinned in.node-versionand@types/nodeto prevent builds from depending on APIs unavailable at the oldest supported runtime.The ticket-resolver example has the only runtime preflight that encodes the supported Node majors, so its acceptance/rejection cases now cover Node 24 as well.
Reproduction
With Node 24 active from the repository root:
pnpm install --frozen-lockfile pnpm run generate:check pnpm run lint pnpm run typecheck pnpm run test:built pnpm run pack:check:built pnpm --filter @zenml-io/kitaru-example-vercel-ai-ticket-resolver testThe install should complete without an unsupported-engine warning, all package checks should pass, and the ticket-resolver preflight tests should accept Node 24 while continuing to reject unsupported majors.
Local checks run
just check: passed, including formatting, lint, OpenAPI drift, changelog, Python type checks, typos, YAML, Actions lint, and offline link checks