fix(utils): Derive Hash manually

har7an · har7an · commit 5a2ca0ecfc07 · 2025-01-19T17:14:38.000+01:00
in `input/layout` since the `PartialEq` trait is also implemented manually. Previously the `Hash` impl wasn't consistent with the `Eq` impl, which can have weird effects when using these types in e.g. `HashMap`s or similar types. For additional information, see: - https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq - https://doc.rust-lang.org/stable/std/hash/trait.Hash.html#hash-and-eq
diff --git a/zellij-utils/src/input/layout.rs b/zellij-utils/src/input/layout.rs
@@ -433,7 +433,7 @@ impl RunPlugin {
     }
 }
 
-#[derive(Debug, Serialize, Deserialize, Clone, Hash, Default, Eq)]
+#[derive(Debug, Serialize, Deserialize, Clone, Default, Eq)]
 pub struct PluginAlias {
     pub name: String,
     pub configuration: Option<PluginUserConfiguration>,
@@ -443,10 +443,19 @@ pub struct PluginAlias {
 
 impl PartialEq for PluginAlias {
     fn eq(&self, other: &Self) -> bool {
+        // NOTE: Keep this in sync with what the `Hash` trait impl does.
         self.name == other.name && self.configuration == other.configuration
     }
 }
 
+impl std::hash::Hash for PluginAlias {
+    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
+        // NOTE: Keep this in sync with what the `PartiqlEq` trait impl does.
+        self.name.hash(state);
+        self.configuration.hash(state);
+    }
+}
+
 impl PluginAlias {
     pub fn new(
         name: &str,
