Replace CADisplayLink with CVDisplayLink#7583
Conversation
Co-Authored-By: Thorsten <[email protected]>
Co-Authored-By: Nathan <[email protected]> Co-Authored-By: Max <[email protected]>
cla-bot
bot
added
the
cla-signed
|
Is this a related issue? When hovering over something, drops the FPS to ~10. Screen.Recording.2024-02-08.at.19.39.33.mov |
Release Notes: - Fixed a bug that caused Zed to render at 60fps even on ProMotion displays. - Fixed a bug that could saturate the main thread event loop in certain circumstances. --------- Co-authored-by: Thorsten <[email protected]> Co-authored-by: Nathan <[email protected]> Co-authored-by: Max <[email protected]>
Release Notes: - Fixed a bug that caused Zed to render at 60fps even on ProMotion displays. - Fixed a bug that could saturate the main thread event loop in certain circumstances. --------- Co-authored-by: Thorsten <[email protected]> Co-authored-by: Nathan <[email protected]> Co-authored-by: Max <[email protected]>
|
@RemcoSmitsDev it could be! Try the latest release, we put the fix in cc @bennetbo 😄 we did it! |
I cannot reproduce it with the stable version but still with the preview version. I'm not sure if the preview version contains the fix. |
|
It actually makes sense that the frame rate drops when no input occurs, we're not producing any new frames because nothing changed on screen and we wanna save battery. |
|
Oh, yes, that. I misunderstood. @RemcoSmitsDev take a look at this video: you can see that if there is something to do, things are rendered, blue line moves. But at the end, I'm just not doing anything, and rendering stops. screenshot-2024-02-09-10.55.13.mp4If I do that on a 60hz display it looks exactly like in your video. |
Okay, makes sense, thanks! But I'm not sure if it's clear on my video, but when I hover over an identifier the popup keeps open until I click somewhere or hover over a new identifier. This happens only on the preview build. Screen.Recording.2024-02-10.at.11.43.06.mov |
|
That seems like a regression unrelated to these changes, as this pull request was hotfixed to stable. I know we recently changed our handling of mouse events on the editor to support clicking on links, maybe @ConradIrwin knows more about this? Either way, would you mind opening a new issue and tagging it as “regression”? Thanks! |
Sure, made the issue: #7670 |
4 participants
Release Notes: