Add .tar.bz2 archive support for ACP agent server downloads#52188
Merged
benbrandt merged 2 commits intozed-industries:mainfrom Mar 25, 2026
Merged
Add .tar.bz2 archive support for ACP agent server downloads#52188benbrandt merged 2 commits intozed-industries:mainfrom
benbrandt merged 2 commits intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @vincenzopalazzo on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
bot
added
the
first contribution
zed-codeowner-coordinator
bot
requested review from
a team,
as-cii and
kubkon
and removed request for
a team
Contributor
Author
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
|
The ACP registry schema allows .tar.bz2 archives, but Zed only supported .zip, .tar.gz, and .tgz. When a registry entry (like Goose) only ships .tar.bz2, Zed would bail with "unsupported archive type". This adds a TarBz2 variant to AssetKind and implements extraction using the bzip2 feature of async-compression (already a workspace dependency).
vincenzopalazzo
force-pushed
the
claude/affectionate-ishizaka
branch
from
227a9eb to
1c7d7a1
Compare
SomeoneToIgnore
added
the
area:ai
Member
|
/cherry-pick preview |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2026
## Summary - Added `TarBz2` variant to `AssetKind` enum for `.tar.bz2` / `.tbz2` archives - Implemented `extract_tar_bz2` using the `bzip2` feature of `async-compression` (already a workspace dependency, just enabled the feature flag) - Wired up both streaming and file-based extraction paths in `github_download.rs` - Added `.tar.bz2` / `.tbz2` URL detection in both `LocalExtensionArchiveAgent` and `LocalRegistryArchiveAgent` This unblocks ACP registry entries (like Goose) that only ship `.tar.bz2` archives. Reference: block/goose#8047 ## Test plan - [ ] Verify `cargo check` and `clippy` pass (confirmed locally) - [ ] Test downloading an ACP agent that ships a `.tar.bz2` archive (e.g., Goose) - [ ] Verify existing `.tar.gz` and `.zip` agent downloads still work Release Notes: - Added support for `.tar.bz2` archives in ACP agent server downloads, unblocking registry entries like Goose that only ship bzip2-compressed tarballs. --------- Co-authored-by: Ben Brandt <[email protected]>
zed-zippy bot
added a commit
that referenced
this pull request
Mar 25, 2026
…(cherry-pick to preview) (#52412) Cherry-pick of #52188 to preview ---- ## Summary - Added `TarBz2` variant to `AssetKind` enum for `.tar.bz2` / `.tbz2` archives - Implemented `extract_tar_bz2` using the `bzip2` feature of `async-compression` (already a workspace dependency, just enabled the feature flag) - Wired up both streaming and file-based extraction paths in `github_download.rs` - Added `.tar.bz2` / `.tbz2` URL detection in both `LocalExtensionArchiveAgent` and `LocalRegistryArchiveAgent` This unblocks ACP registry entries (like Goose) that only ship `.tar.bz2` archives. Reference: block/goose#8047 ## Test plan - [ ] Verify `cargo check` and `clippy` pass (confirmed locally) - [ ] Test downloading an ACP agent that ships a `.tar.bz2` archive (e.g., Goose) - [ ] Verify existing `.tar.gz` and `.zip` agent downloads still work Release Notes: - Added support for `.tar.bz2` archives in ACP agent server downloads, unblocking registry entries like Goose that only ship bzip2-compressed tarballs. --------- Co-authored-by: Ben Brandt <[email protected]> Co-authored-by: Vincenzo Palazzo <[email protected]> Co-authored-by: Ben Brandt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TarBz2variant toAssetKindenum for.tar.bz2/.tbz2archivesextract_tar_bz2using thebzip2feature ofasync-compression(already a workspace dependency, just enabled the feature flag)github_download.rs.tar.bz2/.tbz2URL detection in bothLocalExtensionArchiveAgentandLocalRegistryArchiveAgentThis unblocks ACP registry entries (like Goose) that only ship
.tar.bz2archives.Reference: block/goose#8047
Test plan
cargo checkandclippypass (confirmed locally).tar.bz2archive (e.g., Goose).tar.gzand.zipagent downloads still workRelease Notes:
.tar.bz2archives in ACP agent server downloads, unblocking registry entries like Goose that only ship bzip2-compressed tarballs.