helix: Unflip default split binds#51962
Merged
bennetbo merged 2 commits intozed-industries:mainfrom Mar 20, 2026
Merged
Conversation
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 20, 2026
## Context Closes zed-industries#51955 Some super easy helix parity. I checked and helix uses these binds for splitting the editor, given these binds are helix specific, it would be weird to just keep them being wrong. ## How to Review just changed the default keymap for helix mode. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - helix: fixed binds for splitting window Co-authored-by: Bennet Bo Fenner <[email protected]>
toshmukhamedov
pushed a commit
to toshmukhamedov/zed
that referenced
this pull request
Mar 20, 2026
## Context Closes zed-industries#51955 Some super easy helix parity. I checked and helix uses these binds for splitting the editor, given these binds are helix specific, it would be weird to just keep them being wrong. ## How to Review just changed the default keymap for helix mode. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - helix: fixed binds for splitting window Co-authored-by: Bennet Bo Fenner <[email protected]>
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 23, 2026
## Context Closes zed-industries#51955 Some super easy helix parity. I checked and helix uses these binds for splitting the editor, given these binds are helix specific, it would be weird to just keep them being wrong. ## How to Review just changed the default keymap for helix mode. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - helix: fixed binds for splitting window Co-authored-by: Bennet Bo Fenner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #51955
Some super easy helix parity. I checked and helix uses these binds for splitting the editor, given these binds are helix specific, it would be weird to just keep them being wrong.
How to Review
just changed the default keymap for helix mode.
Self-Review Checklist
Release Notes: