anthropic: Add support for thinking toggle#51946
Merged
Conversation
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
staff
Co-authored-by: Marshall Bowers <[email protected]>
Co-authored-by: Marshall Bowers <[email protected]>
zed-codeowner-coordinator
bot
requested review from
a team,
osyvokon and
rtfeldman
and removed request for
a team
maxdeviant
approved these changes
Mar 19, 2026
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 20, 2026
This adds support for the thinking toggle + reasoning effort for the Anthropic provider Release Notes: - anthropic: Added support for selecting reasoning effort --------- Co-authored-by: Marshall Bowers <[email protected]>
toshmukhamedov
pushed a commit
to toshmukhamedov/zed
that referenced
this pull request
Mar 20, 2026
This adds support for the thinking toggle + reasoning effort for the Anthropic provider Release Notes: - anthropic: Added support for selecting reasoning effort --------- Co-authored-by: Marshall Bowers <[email protected]>
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 23, 2026
This adds support for the thinking toggle + reasoning effort for the Anthropic provider Release Notes: - anthropic: Added support for selecting reasoning effort --------- Co-authored-by: Marshall Bowers <[email protected]>
|
Where on earth is this? :) |
Closed
5 tasks
5 tasks
osyvokon
pushed a commit
that referenced
this pull request
Apr 14, 2026
…refactor (#52975) PR #51946 broke `Model::Custom` thinking behavior: `mode()`, `supports_thinking()`, and `supports_adaptive_thinking()` all inferred capabilities from hardcoded built-in model lists, so any `Custom` variant always fell back to `Default` regardless of its configured `mode` field. ### Fixes - **`Model::mode()`** — `Custom` now short-circuits to `mode.clone()` before the built-in inference logic - **`Model::supports_thinking()`** — `Custom` returns `true` when `mode` is `Thinking { .. }` or `AdaptiveThinking` - **`Model::supports_adaptive_thinking()`** — `Custom` returns `true` when `mode` is `AdaptiveThinking` Built-in model behavior is unchanged. ### Tests Three regression tests added covering the three `Custom` mode cases: explicit `Thinking`, `AdaptiveThinking`, and `Default` (which must disable both flags). Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed custom Anthropic models losing their configured thinking/adaptive-thinking mode after the thinking-toggle refactor (#51946) --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]>
nathansobo
pushed a commit
that referenced
this pull request
Apr 14, 2026
…refactor (#52975) PR #51946 broke `Model::Custom` thinking behavior: `mode()`, `supports_thinking()`, and `supports_adaptive_thinking()` all inferred capabilities from hardcoded built-in model lists, so any `Custom` variant always fell back to `Default` regardless of its configured `mode` field. ### Fixes - **`Model::mode()`** — `Custom` now short-circuits to `mode.clone()` before the built-in inference logic - **`Model::supports_thinking()`** — `Custom` returns `true` when `mode` is `Thinking { .. }` or `AdaptiveThinking` - **`Model::supports_adaptive_thinking()`** — `Custom` returns `true` when `mode` is `AdaptiveThinking` Built-in model behavior is unchanged. ### Tests Three regression tests added covering the three `Custom` mode cases: explicit `Thinking`, `AdaptiveThinking`, and `Default` (which must disable both flags). Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed custom Anthropic models losing their configured thinking/adaptive-thinking mode after the thinking-toggle refactor (#51946) --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the thinking toggle + reasoning effort for the Anthropic provider
Release Notes: