Skip to content

editor: Place cursor at clicked column when clicking sticky headers#51911

Merged
Veykril merged 1 commit intomainfrom
veykril/push-wpxtovmlvkll
Mar 19, 2026
Merged

editor: Place cursor at clicked column when clicking sticky headers#51911
Veykril merged 1 commit intomainfrom
veykril/push-wpxtovmlvkll

Conversation

@Veykril
Copy link
Copy Markdown
Member

@Veykril Veykril commented Mar 19, 2026

When clicking on a sticky header line, the cursor is now placed at the column corresponding to the click position, rather than always at the start of the outline item's range. The hover cursor is also changed from a pointing hand to an I-beam to reflect that clicking behaves like clicking in normal editor text.

Release Notes:

  • Clicking a sticky header now puts the cursor at the clicked column

When clicking on a sticky header line, the cursor is now placed at the
column corresponding to the click position, rather than always at the
start of the outline item's range. The hover cursor is also changed from
a pointing hand to an I-beam to reflect that clicking behaves like
clicking in normal editor text.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 19, 2026
@Veykril Veykril enabled auto-merge (squash) March 19, 2026 08:52
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested a review from a team March 19, 2026 08:52
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Mar 19, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from cole-miller and dinocosta and removed request for a team March 19, 2026 08:52
@Veykril Veykril disabled auto-merge March 19, 2026 08:57
Copy link
Copy Markdown
Member

@cole-miller cole-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this feels a little bit weird to me because you can't click and drag to select even though there's an I-beam, but also seems reasonable and implementation looks good

@Veykril Veykril merged commit e5150ab into main Mar 19, 2026
41 checks passed
@Veykril Veykril deleted the veykril/push-wpxtovmlvkll branch March 19, 2026 13:49
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 20, 2026
…ed-industries#51911)

When clicking on a sticky header line, the cursor is now placed at the
column corresponding to the click position, rather than always at the
start of the outline item's range. The hover cursor is also changed from
a pointing hand to an I-beam to reflect that clicking behaves like
clicking in normal editor text.

Release Notes:

- Clicking a sticky header now puts the cursor at the clicked column
toshmukhamedov pushed a commit to toshmukhamedov/zed that referenced this pull request Mar 20, 2026
…ed-industries#51911)

When clicking on a sticky header line, the cursor is now placed at the
column corresponding to the click position, rather than always at the
start of the outline item's range. The hover cursor is also changed from
a pointing hand to an I-beam to reflect that clicking behaves like
clicking in normal editor text.

Release Notes:

- Clicking a sticky header now puts the cursor at the clicked column
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 23, 2026
…ed-industries#51911)

When clicking on a sticky header line, the cursor is now placed at the
column corresponding to the click position, rather than always at the
start of the outline item's range. The hover cursor is also changed from
a pointing hand to an I-beam to reflect that clicking behaves like
clicking in normal editor text.

Release Notes:

- Clicking a sticky header now puts the cursor at the clicked column
@timvermeulen
Copy link
Copy Markdown
Contributor

Using this feels a little bit weird to me because you can't click and drag to select even though there's an I-beam

Apparently #52636 (inadvertently) introduced click and drag to select here, conveniently!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement size/S staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants