Skip to content

vim: Add helix alias reflow for vim rewrap#51788

Merged
dinocosta merged 4 commits intozed-industries:mainfrom
bbarker:helix_rewrap
Mar 20, 2026
Merged

vim: Add helix alias reflow for vim rewrap#51788
dinocosta merged 4 commits intozed-industries:mainfrom
bbarker:helix_rewrap

Conversation

@bbarker
Copy link
Copy Markdown
Contributor

@bbarker bbarker commented Mar 17, 2026 •
edited by dinocosta
Loading

Screenshot 2026-03-17 at 2 34 13 PM Screenshot 2026-03-17 at 2 34 32 PM

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • Add support for helix's :reflow command

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 17, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @bbarker on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 17, 2026
@maxdeviant maxdeviant changed the title add helix alias 'reflow' for vim rewrap vim: Add helix alias reflow for vim rewrap Mar 17, 2026
@bbarker
Copy link
Copy Markdown
Contributor Author

bbarker commented Mar 17, 2026

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 17, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 17, 2026

The cla-bot has been summoned, and re-checked this pull request!

dinocosta
dinocosta reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dinocosta dinocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggesting this change @bbarker !

Changes look good to me. Are you able to also add a test for this change? There's already some examples in that same crates/vim/src/command.rs file that you can probably leverage. Let me know if you're struggling to add a test and I can also take a look. Thanks! ✌️

@dinocosta dinocosta merged commit 22a33b7 into zed-industries:main Mar 20, 2026
30 checks passed
@dinocosta dinocosta mentioned this pull request Mar 23, 2026
Merged
5 tasks
@bbarker
Copy link
Copy Markdown
Contributor Author

bbarker commented Mar 23, 2026

Thanks, was traveling - i'll try to remember those tests next time!

AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 23, 2026
@bbarker @dinocosta @AmaanBilwar
vim: Add helix alias reflow for vim rewrap (zed-industries#51788)
bfba6dd 
Add support for Helix's `:reflow` command when vim or helix mode is
enabled.

Release Notes:

- Add support for helix's `:reflow` command

---------

Co-authored-by: dino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dinocosta dinocosta dinocosta left review comments

Assignees

@kubkon kubkon

@dinocosta dinocosta

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbarker @dinocosta @kubkon