Skip to content

languages: Fix semantic tokens for Go#51621

Merged
Veykril merged 1 commit intozed-industries:mainfrom
feitreim:bugfix-semantic-tokens
Mar 17, 2026
Merged

languages: Fix semantic tokens for Go#51621
Veykril merged 1 commit intozed-industries:mainfrom
feitreim:bugfix-semantic-tokens

Conversation

@feitreim
Copy link
Copy Markdown
Contributor

Closes #51620

gopls requires more specific initialization for semantic tokens that other language-servers for reasons that aren't entirely clear to me, it is however a small fix to make it work. still trying to track down other malfunctioning language servers in the semantic token realm, so if you have suggestions let me know.

original behavior (on nightly v0.229):
nightly_behavior

updated behavior:
fix_applied

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • gopls: fixed semantic token support with gopls.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 15, 2026
@maxdeviant maxdeviant changed the title fixed gopls semantic tokens languages: Fix semantic tokens for Go Mar 15, 2026
Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril merged commit 5b6201d into zed-industries:main Mar 17, 2026
33 checks passed
@Veykril Veykril self-assigned this Mar 17, 2026
@feitreim feitreim deleted the bugfix-semantic-tokens branch March 17, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gopls language server fails to send semantic tokens to zed.

2 participants