project: Fix empty files not downloading from a remote project#51571
Merged
Veykril merged 1 commit intozed-industries:mainfrom Mar 17, 2026
Merged
Conversation
- entry is removed from `downloading_files` - empty filw is writte via `smol::fs::write(..., &[])` this means the receiver handlesthe empty files completely as soon as the Stae message arrieves, without ever needing a Chunk that will never come
cla-bot
bot
added
the
cla-signed
zelenenka
added
the
guild
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
content_size==0downloading_filessmol::fs::write(..., &[])this means the receiver handles the empty files completely as soon as the State message arrives, without ever needing a Chunk that will never come
Closes #51551
Before you mark this PR as ready for review, make sure that you have:
Release Notes: