languages: Exclude angle brackets from rainbow bracket colorization for TSX#51311
Merged
MrSubidubi merged 1 commit intozed-industries:mainfrom Mar 11, 2026
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @jackkkonggg on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
bot
added
the
first contribution
maxdeviant
changed the title
MrSubidubi
changed the title
MrSubidubi
approved these changes
Mar 11, 2026
Member
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Yeah, very valid. Thank you!
Member
|
Will need you to sign the CLA though |
Contributor
Author
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
approved these changes
Mar 11, 2026
Member
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Perfect, thanks! And congratulations to your first contribution! 🎉
Contributor
Author
My first OSS contribution! Looking forward to doing more. |
tommyming
pushed a commit
to tommyming/zed
that referenced
this pull request
Mar 13, 2026
…or TSX (zed-industries#51311) ## Summary Angle brackets in TSX (`<`, `>`, `/>`, `</`) are always paired with JSX tag syntax — they don't indicate bracket nesting depth — so rainbow colorization adds noise without useful information. This mirrors zed-industries#46808, which applied the same fix to the HTML extension. ## Changes - Added `(#set! rainbow.exclude)` to all three angle bracket patterns in `crates/languages/src/tsx/brackets.scm` ## Before / After Before: angle brackets in JSX tags receive rainbow colors alongside `{}`, `()`, `[]`, making every tag visually noisy. After: only `{}`, `()`, and `[]` receive rainbow colors — angle brackets are excluded, matching the HTML extension behavior. > Screenshots: I don't have a built copy of Zed handy to attach — happy to add one if a maintainer needs it before merging. Release Notes: - Removed rainbow bracket colorization for angled brackets within TSX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Angle brackets in TSX (
<,>,/>,</) are always paired with JSX tag syntax — they don't indicate bracket nesting depth — so rainbow colorization adds noise without useful information.This mirrors #46808, which applied the same fix to the HTML extension.
Changes
(#set! rainbow.exclude)to all three angle bracket patterns incrates/languages/src/tsx/brackets.scmBefore / After
Before: angle brackets in JSX tags receive rainbow colors alongside
{},(),[], making every tag visually noisy.After: only
{},(), and[]receive rainbow colors — angle brackets are excluded, matching the HTML extension behavior.Release Notes: