languages: Validate pylsp binary before returning from check_if_user_installed#51034
Merged
Veykril merged 1 commit intozed-industries:mainfrom Mar 11, 2026
Merged
Conversation
Run `pylsp --version` via `delegate.try_exec()` in both branches of `PyLspAdapter::check_if_user_installed` before returning the binary. If execution fails (broken shebang, missing interpreter, etc.), log a warning and return None so the system falls through gracefully instead of surfacing an error dialog. This matches the existing validation pattern used by TyLspAdapter and RuffLspAdapter in their `fetch_server_binary` implementations.
cla-bot
bot
added
the
cla-signed
github-actions
bot
added
the
community champion
Veykril
approved these changes
Mar 11, 2026
Member
|
Thanks! |
Veykril
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
pylsp --versionviadelegate.try_exec()in both branches ofPyLspAdapter::check_if_user_installedbefore returning the binary. If execution fails (broken shebang, missing interpreter, etc.), log a warning and return None so the system falls through gracefully instead of surfacing an error dialog.This matches the existing validation pattern used by TyLspAdapter and RuffLspAdapter in their
fetch_server_binaryimplementations.No idea if this closes an issue but it sure was annoying on a system where I deleted the pylsp environment I had. It surprised me too since I had pylsp disabled in settings.
Release Notes:
pylspis not installed properly on a user's system so that it doesn't get launched as an LSP when it doesn't exist.