Fix "Show Edit Predictions For This Buffer" button#50845
Merged
probably-neb merged 1 commit intozed-industries:mainfrom Mar 17, 2026
Merged
Fix "Show Edit Predictions For This Buffer" button#50845probably-neb merged 1 commit intozed-industries:mainfrom
probably-neb merged 1 commit intozed-industries:mainfrom
Conversation
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
first contribution
SomeoneToIgnore
added
the
area:ai
zelenenka
added
the
guild
Collaborator
|
Nice work tracking this down, glad it was a simple fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48393
When switching the language of an unsaved buffer (e.g., from Plain Text to JavaScript), the editor's edit_prediction_settings were not recalculated. This caused the "This Buffer" toggle in the edit prediction menu to show a stale state, making the first click a no-op. I added a call to update_edit_prediction_settings in the LanguageChanged event handler so the editor immediately reflects the correct edit prediction state for the new language.
Before you mark this PR as ready for review, make sure that you have:
Release Notes: