agent_ui: Mask API key input in Add LLM provider modal#50379
Merged
danilo-leal merged 6 commits intozed-industries:mainfrom Mar 13, 2026
Merged
agent_ui: Mask API key input in Add LLM provider modal#50379danilo-leal merged 6 commits intozed-industries:mainfrom
danilo-leal merged 6 commits intozed-industries:mainfrom
Conversation
Signed-off-by: Xiaobo Liu <[email protected]>
cla-bot
bot
added
the
cla-signed
SomeoneToIgnore
added
the
area:ai
danilo-leal
requested changes
Mar 2, 2026
Member
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR! I don't think we should mask this by default, though. If we did that, how could you double check whether the API key is correct, like, free from typos or any other mistake? I think the pattern we'd like to follow here, if anything, is having the typical input "eye" icon button that allows you to toggle the mask on and off.
Contributor
Author
|
Hi @danilo-leal , The eye icon button added. 2026-03-04.20.56.50.mov |
danilo-leal
approved these changes
Mar 13, 2026
Member
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Thank you so much! Pushed a change here embedding the hide/show icon button directly in the input field. It would be great later on to add the ability to toggle it with the keyboard somehow!
tommyming
pushed a commit
to tommyming/zed
that referenced
this pull request
Mar 15, 2026
…s#50379) Release Notes: - Added Mask API key input in Add LLM provider modal <img width="427" height="430" alt="截屏2026-02-28 17 35 22" src="https://github.com/user-attachments/assets/ae628815-f7df-4ea0-90ea-a23bbd703521" /> --------- Signed-off-by: Xiaobo Liu <[email protected]> Co-authored-by: Danilo Leal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: