settings_ui: Improve control alignment for multiline settings rows#49850
Merged
danilo-leal merged 2 commits intozed-industries:mainfrom Feb 24, 2026
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @altaywtf on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
bot
added
the
first contribution
Contributor
Author
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
danilo-leal
approved these changes
Feb 24, 2026
Member
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Thank you! I've removed all the item_starts because I do want to keep things centered-aligned. But the width fix is a good one, so we're keeping that :) Appreciate it!
Anthony-Eid
pushed a commit
to bobbymannino/zed
that referenced
this pull request
Feb 25, 2026
…ed-industries#49850) Closes zed-industries#49848 Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) ## Summary Align right-side controls in settings rows when descriptions wrap to multiple lines, and relax the text-width cap for better balance. ## Changes - Top-aligned settings row containers in shared settings UI render paths by adding `items_start()` to: - Setting rows (`render_settings_item`) - Sub-page link rows - Action link rows - Updated the left text column width constraint in `render_settings_item` from `w_3_4` to `w_full + max_w_2_3 + min_w_0` to avoid overlap while reducing excess empty space. ## Validation - Built and ran Zed locally with `cargo run`. - Manual verification in Settings pages with multiline descriptions and right-side controls: - General - Appearance - Languages & Tools - Agent/Terminal-related sections - Confirmed improved control alignment and no right-column text overlap in the tested views. | Before | After | |---|---| |  |  | |  |  | ## Linked Issues - zed-industries#49848 Release Notes: - Fixed settings row layout so right-side controls align better with multiline setting descriptions. --------- Co-authored-by: Danilo Leal <[email protected]>
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…ed-industries#49850) Closes zed-industries#49848 Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) ## Summary Align right-side controls in settings rows when descriptions wrap to multiple lines, and relax the text-width cap for better balance. ## Changes - Top-aligned settings row containers in shared settings UI render paths by adding `items_start()` to: - Setting rows (`render_settings_item`) - Sub-page link rows - Action link rows - Updated the left text column width constraint in `render_settings_item` from `w_3_4` to `w_full + max_w_2_3 + min_w_0` to avoid overlap while reducing excess empty space. ## Validation - Built and ran Zed locally with `cargo run`. - Manual verification in Settings pages with multiline descriptions and right-side controls: - General - Appearance - Languages & Tools - Agent/Terminal-related sections - Confirmed improved control alignment and no right-column text overlap in the tested views. | Before | After | |---|---| |  |  | |  |  | ## Linked Issues - zed-industries#49848 Release Notes: - Fixed settings row layout so right-side controls align better with multiline setting descriptions. --------- Co-authored-by: Danilo Leal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49848
Before you mark this PR as ready for review, make sure that you have:
Summary
Align right-side controls in settings rows when descriptions wrap to multiple lines, and relax the text-width cap for better balance.
Changes
items_start()to:render_settings_item)render_settings_itemfromw_3_4tow_full + max_w_2_3 + min_w_0to avoid overlap while reducing excess empty space.Validation
Built and ran Zed locally with
cargo run.Manual verification in Settings pages with multiline descriptions and right-side controls:
Confirmed improved control alignment and no right-column text overlap in the tested views.
Linked Issues
Release Notes: