auto_update: Persist custom icons across app updates on macOS#49727
Merged
ConradIrwin merged 1 commit intozed-industries:mainfrom Feb 24, 2026
Merged
auto_update: Persist custom icons across app updates on macOS#49727ConradIrwin merged 1 commit intozed-industries:mainfrom
ConradIrwin merged 1 commit intozed-industries:mainfrom
Conversation
This change adds `--exclude "Icon?"` to the rsync command arguments when installing updates on macOS, preventing the hidden Icon? files from being copied or deleted during the update process.
cla-bot
bot
added
the
cla-signed
github-actions
bot
added
the
community champion
maxdeviant
changed the title
amtoaer
changed the title
JosephTLyons
approved these changes
Feb 24, 2026
Member
|
Thanks for this! |
pull bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 24, 2026
…dustries#49727) After setting a custom icon on macOS, an `Icon\r` file is generated in the application's root directory to store the custom icon metadata. Currently, the update process uses `rsync -av --delete`, which removes this `Icon\r` file and causes the custom icon to revert to the default blue folder. This PR adds the `--exclude 'Icon?'` parameter to ensure the file is preserved during updates. Closes zed-industries#26639 , Closes zed-industries#29900. Since I cannot trigger the auto-update mechanism manually, I mounted the latest Zed disk image and simulated the update by executing the rsync command in the terminal to verify the fix. <img width="2254" height="1596" alt="图片" src="https://github.com/user-attachments/assets/26660fa4-447f-427a-b2dd-e6280ce3d42d" /> Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed an issue where custom macOS app icons would revert to default blue folders after an update.
pull bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…dustries#49727) After setting a custom icon on macOS, an `Icon\r` file is generated in the application's root directory to store the custom icon metadata. Currently, the update process uses `rsync -av --delete`, which removes this `Icon\r` file and causes the custom icon to revert to the default blue folder. This PR adds the `--exclude 'Icon?'` parameter to ensure the file is preserved during updates. Closes zed-industries#26639 , Closes zed-industries#29900. Since I cannot trigger the auto-update mechanism manually, I mounted the latest Zed disk image and simulated the update by executing the rsync command in the terminal to verify the fix. <img width="2254" height="1596" alt="图片" src="https://github.com/user-attachments/assets/26660fa4-447f-427a-b2dd-e6280ce3d42d" /> Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed an issue where custom macOS app icons would revert to default blue folders after an update.
pull bot
pushed a commit
to FlorianDevP/zed
that referenced
this pull request
Feb 25, 2026
…dustries#49727) After setting a custom icon on macOS, an `Icon\r` file is generated in the application's root directory to store the custom icon metadata. Currently, the update process uses `rsync -av --delete`, which removes this `Icon\r` file and causes the custom icon to revert to the default blue folder. This PR adds the `--exclude 'Icon?'` parameter to ensure the file is preserved during updates. Closes zed-industries#26639 , Closes zed-industries#29900. Since I cannot trigger the auto-update mechanism manually, I mounted the latest Zed disk image and simulated the update by executing the rsync command in the terminal to verify the fix. <img width="2254" height="1596" alt="图片" src="https://github.com/user-attachments/assets/26660fa4-447f-427a-b2dd-e6280ce3d42d" /> Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed an issue where custom macOS app icons would revert to default blue folders after an update.
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…dustries#49727) After setting a custom icon on macOS, an `Icon\r` file is generated in the application's root directory to store the custom icon metadata. Currently, the update process uses `rsync -av --delete`, which removes this `Icon\r` file and causes the custom icon to revert to the default blue folder. This PR adds the `--exclude 'Icon?'` parameter to ensure the file is preserved during updates. Closes zed-industries#26639 , Closes zed-industries#29900. Since I cannot trigger the auto-update mechanism manually, I mounted the latest Zed disk image and simulated the update by executing the rsync command in the terminal to verify the fix. <img width="2254" height="1596" alt="图片" src="https://github.com/user-attachments/assets/26660fa4-447f-427a-b2dd-e6280ce3d42d" /> Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed an issue where custom macOS app icons would revert to default blue folders after an update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After setting a custom icon on macOS, an
Icon\rfile is generated in the application's root directory to store the custom icon metadata. Currently, the update process usesrsync -av --delete, which removes thisIcon\rfile and causes the custom icon to revert to the default blue folder.This PR adds the
--exclude 'Icon?'parameter to ensure the file is preserved during updates.Closes #26639 , Closes #29900.
Since I cannot trigger the auto-update mechanism manually, I mounted the latest Zed disk image and simulated the update by executing the rsync command in the terminal to verify the fix.
Before you mark this PR as ready for review, make sure that you have:
Release Notes: