Skip to content

image_viewer: Use checkerboard from GPUI#49575

Merged
Anthony-Eid merged 2 commits intozed-industries:mainfrom
MostlyKIGuess:feature/add-check-shader
Feb 24, 2026
Merged

image_viewer: Use checkerboard from GPUI#49575
Anthony-Eid merged 2 commits intozed-industries:mainfrom
MostlyKIGuess:feature/add-check-shader

Conversation

@MostlyKIGuess
Copy link
Copy Markdown
Contributor

@MostlyKIGuess MostlyKIGuess commented Feb 19, 2026

As we have checkerboard, used same pattern as git diff inside Image Viewer.
Now that CPU instructions aren't an issue, perhaps size can be lowered to 16/24 for base boxes.

Release Notes:

  • Made the checkerboard pattern in the image viewer more visually pleasant.

@MostlyKIGuess MostlyKIGuess requested a review from a team as a code owner February 19, 2026 09:38
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 19, 2026
@MrSubidubi MrSubidubi self-assigned this Feb 19, 2026
@maxdeviant maxdeviant changed the title image_viewer: Use checkerboard from gpui image_viewer: Use checkerboard from GPUI Feb 19, 2026
@MrSubidubi
Copy link
Copy Markdown
Member

perhaps size can be lowered to 16/24 for base boxes

Yep, I think that sounds good! Feel free to go with what you think looks best

@MostlyKIGuess
Copy link
Copy Markdown
Contributor Author

perhaps size can be lowered to 16/24 for base boxes

Yep, I think that sounds good! Feel free to go with what you think looks best

32 looked nice :D

Copy link
Copy Markdown
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to agree, it indeed does ^^

Only thing I'd want to discuss: Do we want to change the colors like this? I'll ping our designer internally, but would like your opinion on it as well.

@Anthony-Eid Anthony-Eid merged commit f375a1a into zed-industries:main Feb 24, 2026
27 checks passed
Copy link
Copy Markdown
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got greenlit by design, we like it much more. Thank you for jumping on this!

Anthony-Eid pushed a commit to bobbymannino/zed that referenced this pull request Feb 25, 2026
As we have checkerboard, used same pattern as git diff inside Image
Viewer.
Now that CPU instructions aren't an issue, perhaps size can be lowered
to 16/24 for base boxes.



Release Notes:

- N/A
tahayvr pushed a commit to tahayvr/zed that referenced this pull request Mar 4, 2026
As we have checkerboard, used same pattern as git diff inside Image
Viewer.
Now that CPU instructions aren't an issue, perhaps size can be lowered
to 16/24 for base boxes.



Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants