Skip to content

buffer_search: Don’t hide UI icons if search query is too large#49493

Merged
dinocosta merged 2 commits intomainfrom
fix-issue-49446-072d39066a7bf9f1
Feb 19, 2026
Merged

buffer_search: Don’t hide UI icons if search query is too large#49493
dinocosta merged 2 commits intomainfrom
fix-issue-49446-072d39066a7bf9f1

Conversation

@yeskunall
Copy link
Copy Markdown
Member

@yeskunall yeskunall commented Feb 18, 2026

The editor scroll handle and width calculations were added to conditionally hide inline search option buttons, but this behavior clashed with how the multi-buffer search UI works.

Closes #49446.

Before After
image image

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • Don’t hide UI icons in buffer search if search query is too large

The editor scroll handle and width calculations were added to
conditionally hide inline search option buttons, but this behavior
clashed with how the multi-buffer search UI works.
@yeskunall yeskunall requested a review from a team as a code owner February 18, 2026 15:47
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 18, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Feb 18, 2026
Copy link
Copy Markdown
Member

@dinocosta dinocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yeskunall ! I've merged main to bring this up to date with the latest changes and see if CI/CD now passes ✌️

@dinocosta dinocosta merged commit 8815573 into main Feb 19, 2026
28 checks passed
@dinocosta dinocosta deleted the fix-issue-49446-072d39066a7bf9f1 branch February 19, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search options are not visible when the search string is long

2 participants