languages: Add first-line C++ language detection for extensionless libcpp headers#47443
Merged
osiewicz merged 2 commits intozed-industries:mainfrom Jan 28, 2026
Merged
Conversation
cla-bot
bot
added
the
cla-signed
ozacod
force-pushed
the
feat/cpp-firstline-pattern
branch
from
08062d2 to
3309318
Compare
maxdeviant
changed the title
ozacod
force-pushed
the
feat/cpp-firstline-pattern
branch
from
3309318 to
d1ad3c1
Compare
Member
|
It seems that there's a conflict with main at the moment. |
ozacod
force-pushed
the
feat/cpp-firstline-pattern
branch
from
d1ad3c1 to
3996c32
Compare
# Conflicts: # crates/languages/src/cpp/config.toml # Conflicts: # crates/languages/src/cpp/config.toml
ozacod
force-pushed
the
feat/cpp-firstline-pattern
branch
from
3996c32 to
370c687
Compare
Contributor
Author
|
Resolved, ready for review. Thank you, |
osiewicz
approved these changes
Jan 28, 2026
|
Thanks a lot! Is it possible to be modified to detect libstdc++ headers also? For example, the first line of |
Contributor
Author
|
@hly1204 it is exactly same pattern so it should be working. |
osiewicz
pushed a commit
that referenced
this pull request
Feb 3, 2026
#47443 (comment) Support detect libstdc++ headers <img width="1335" height="830" src="https://github.com/user-attachments/assets/4a8b8376-029b-41c5-a53b-d1a02a061818" /> Release Notes: - N/A
adb-sh
pushed a commit
to adb-sh/zed
that referenced
this pull request
Feb 5, 2026
…s#48250) zed-industries#47443 (comment) Support detect libstdc++ headers <img width="1335" height="830" src="https://github.com/user-attachments/assets/4a8b8376-029b-41c5-a53b-d1a02a061818" /> Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several libcpp headers lack file extensions. Added a first line pattern for recognition.
https://github.com/llvm/llvm-project/blob/main/libcxx/include/random)](https://github.com/llvm/llvm-project/blob/main/libcxx/include/random
Before:
After:
Release Notes: