Add configurable REPL output size limits by cvanelteren · Pull Request #47114 · zed-industries/zed

cvanelteren · 2026-01-18T23:23:39Z

Adds configurable REPL output size limits with two new settings, repl.output_max_height_lines and repl.output_max_width_columns, so large outputs scroll instead of expanding and images scale down to fit the available space. The output containers in both inline REPL blocks and notebook cells now respect these bounds, and image sizing uses the same text metrics as the terminal output for consistent column-based width calculations.

Release Notes:

REPL output now supports configurable max height and width limits, with large outputs scrolling and images scaling to stay within the viewport.

rgbkrk · 2026-01-22T18:32:08Z

crates/repl/src/outputs/plain.rs

+    let font_id = text_system.resolve_font(&text_style.font());
+    let cell_width = text_system
+        .advance(font_id, font_pixels, 'w')
+        .unwrap()


Have a default come out here instead of unwrapping, if it seems sensible. That or return None as bailing would be worse than falling back to None.

Implemented, thanks.

rgbkrk · 2026-01-22T18:34:16Z

docs/src/configuring-zed.md

@@ -21,7 +21,4730 @@ As you type in the search box, matching settings appear with descriptions and co

 ### User Settings

-Your user settings apply globally across all projects. Open the file with {#kb zed::OpenSettingsFile} or run `zed: open settings file` from the command palette.


Did you mean to make all these changes to the configuring zed document? I have no opinions on the content but this should not be in this PR.

rgbkrk

This is sensible. Thanks for the contribution. Only two things to address - the unwrap in max_width_for_columns and removing the changes from docs/src/configuring-zed.md.

cvanelteren · 2026-01-22T22:54:00Z

Thanks @rgbkrk -- I had an old version of the zed repo fork hence the weird docs. Should be good now.

rgbkrk · 2026-01-23T20:42:59Z

docs/src/configuring-zed.md

@@ -1,136 +1,4998 @@
 # Configuring Zed


Can you do a git checkout from main for this file so that we don't have any changes in this file?

Not sure what went wrong there -- it is restored now

miguelraz · 2026-01-28T01:03:25Z

crates/repl/src/notebook/cell.rs

+                                .px_5()
+                                .rounded_lg()
+                                .border_1()
+                                // .border_color(cx.theme().colors().border)


These comments should be deleted now.

Thanks done.

miguelraz · 2026-01-28T01:03:48Z

crates/repl/src/notebook/cell.rs

+                                            };
+
+                                            div()
+                                                // .w_full()


These comments also should be deleted if they're not being used

Thanks. Done.

cvanelteren · 2026-02-02T22:20:53Z

@miguelraz is there anything else that needs to change?

miguelraz · 2026-02-02T22:28:14Z

@cvanelteren Yes, I think some basic unit tests are indispensable here. The repl crate doesn't have many tests to start with and it would be healthy for test coverage to grow, IMO.

@rgbkrk has approved the implementation changes and I see nothing to change there.

cvanelteren · 2026-02-02T23:45:58Z

Added some basic tests @miguelraz; ping me if you need more.

miguelraz · 2026-02-03T03:22:13Z

LGTM - I don't see any of the float checks going haywire in our pixel-calculating conditions, so they unit tests seem sound.

There are some clippy tests you should address @cvanelteren.

cvanelteren · 2026-02-03T03:58:56Z

Passing locally @miguelraz

cvanelteren · 2026-02-03T21:10:11Z

Thanks @miguelraz; I am not following the release schedule closely on zed, when would this be released on preview?

miguelraz · 2026-02-04T04:30:13Z

@cvanelteren should make it into Preview and Nightly tomorrow :)

Closes zed-industries#47113 Adds configurable REPL output size limits with two new settings, `repl.output_max_height_lines` and `repl.output_max_width_columns`, so large outputs scroll instead of expanding and images scale down to fit the available space. The output containers in both inline REPL blocks and notebook cells now respect these bounds, and image sizing uses the same text metrics as the terminal output for consistent column-based width calculations. Release Notes: - REPL output now supports configurable max height and width limits, with large outputs scrolling and images scaling to stay within the viewport.

Key changes: - Reduce monomorphizations in GPUI app.rs (zed-industries#48014) - Entities no longer implement Element directly, go through AnyElement (zed-industries#48217) - D3D11 resource upload optimization (zed-industries#48282) - Migrate features.edit_prediction_provider to edit_predictions.provider (zed-industries#48224) - Make mercury and sweep non-experimental (zed-industries#48227) - CompanionView consolidation in block_map (zed-industries#48223) - Show memory used by language servers (zed-industries#48226) - Settings links open sub pages (zed-industries#48212) - Tool security rules that can't be overridden (zed-industries#48209) - Add sweep_ai privacy mode setting (zed-industries#48220) - Configurable REPL output size limits (zed-industries#47114) - Fix .editorconfig files in subdirectories (zed-industries#48203) - Security updates: bytes v1.11.1, jsonwebtoken v10 - Git UI: hide "View on GitHub" for stashes (zed-industries#48271) - Indent guide fix in tree view with collapsed folders (zed-industries#48194) - Edit prediction fixes and improvements Conflict resolution: - collab/completion.rs, collab/rpc.rs: deleted (collab removed) - vim/search.rs: deleted (vim removed) - livekit_api/Cargo.toml: deleted (livekit removed) - GPUI files: deleted from Glass (handled in Obsydian-HQ/gpui) - migrations: combined both ours (m_2026_02_06) and upstream (m_2026_02_02, m_2026_02_03) - project.rs: kept collab functions removed, restored handle_create_file_for_peer for remote dev - lsp_store.rs: removed collab-only set_language_server_statuses_from_proto - proto.rs: kept CreateFileForPeer, removed CreateChannel/CreateChannelResponse - remote_servers.rs: merged import lists (kept native button imports + added Action) Co-Authored-By: Claude Opus 4.6 <[email protected]>

Continues #47114 Release Notes: - Fixed REPL output width clamping to apply to the content area so images don’t get clipped by controls --------- Co-authored-by: MrSubidubi <[email protected]>

Continues zed-industries#47114 Release Notes: - Fixed REPL output width clamping to apply to the content area so images don’t get clipped by controls --------- Co-authored-by: MrSubidubi <[email protected]>

Add configurable REPL output size limits

3b43451

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 18, 2026

Merge branch 'main' into repl-output-max-height

39f9d9e

SomeoneToIgnore assigned rgbkrk Jan 22, 2026

rgbkrk reviewed Jan 22, 2026

View reviewed changes

rgbkrk suggested changes Jan 22, 2026

View reviewed changes

rgbkrk added the area:repl repl, jupyter, notebooks, etc label Jan 22, 2026

cvanelteren added 3 commits January 23, 2026 08:38

restore configuring zed doc

8e3b278

Add default for cell-width rather than bailing

433c2e1

Merge remote-tracking branch 'zed/main' into repl-output-max-height

d73910b

cvanelteren requested a review from rgbkrk January 22, 2026 22:48

rgbkrk reviewed Jan 23, 2026

View reviewed changes

Restoring file

57b96c8

rgbkrk approved these changes Jan 24, 2026

View reviewed changes

cvanelteren added 3 commits January 25, 2026 17:46

Fix repl output scroll element ids

b4785da

Fix repl output render chaining

eea0c91

Fix repl output size types

6db794b

rgbkrk approved these changes Jan 25, 2026

View reviewed changes

miguelraz reviewed Jan 28, 2026

View reviewed changes

cvanelteren added 2 commits January 28, 2026 11:30

remove comments

bf3e111

Merge branch 'main' into repl-output-max-height

f3fd7f8

Add REPL output sizing tests

62b0aa8

Fix remote connection handling and REPL JSON output

0296ac2

Fix clippy

aa835f2

miguelraz enabled auto-merge (squash) February 3, 2026 04:28

miguelraz merged commit 602d64f into zed-industries:main Feb 3, 2026
27 checks passed

cvanelteren deleted the repl-output-max-height branch February 3, 2026 21:10

cvanelteren mentioned this pull request Feb 5, 2026

repl: Fix image scaling #48435

Merged

		@@ -21,7 +21,4730 @@ As you type in the search box, matching settings appear with descriptions and co

		### User Settings

		Your user settings apply globally across all projects. Open the file with {#kb zed::OpenSettingsFile} or run `zed: open settings file` from the command palette.

Uh oh!

Conversation

cvanelteren commented Jan 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rgbkrk left a comment

Choose a reason for hiding this comment

Uh oh!

cvanelteren commented Jan 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miguelraz Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cvanelteren commented Feb 2, 2026

Uh oh!

miguelraz commented Feb 2, 2026

Uh oh!

cvanelteren commented Feb 2, 2026

Uh oh!

miguelraz commented Feb 3, 2026

Uh oh!

cvanelteren commented Feb 3, 2026

Uh oh!

Uh oh!

cvanelteren commented Feb 3, 2026

Uh oh!

miguelraz commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

miguelraz Jan 28, 2026 •

edited

Loading