We require contributors to sign our Contributor License Agreement, and we don't have @IsraelAraujo70 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Release Notes:

- Added/Fixed/Improved ...

Release Notes:

- N/A

Generated by 🚫 dangerJS against 5d63d25

@cla-bot check

The cla-bot has been summoned, and re-checked this pull request!

example image of the git graph

The author and commit columns overlap if the author string is too long

I also noticed the commit always receiving the click when the user intends to click on the scrollbar

Sure, i will also try to make the lines connect.

@Anthony-Eid : is this the official ui that zed wants?
At the time @zanmato had made a beautiful UI in my opinion.

Look: #39595

@Angelk90 its really more pretty!
Why did they close tho?
I will try to replicate what the other guy did.

@IsraelAraujo70 : I'll give you a piece of advice, so you don't waste time.
Have you contacted the Zed staff to find out the exact UI for this feature and how it should be implemented?

Is it part of their current plans?

Read here: #39595 (comment)

No actually, this was the only thing I missed from vsc, so I was just implementing for myself.
I really think the zed staff would approve PR 39595 as preview and then later on zed 1.0 give it a rework with the work they intended.

@IsraelAraujo70 : I'll give you a piece of advice, so you don't waste time.
Have you contacted the Zed staff to find out the exact UI for this feature and how it should be implemented?

Is it part of their current plans?

Read here: #39595 (comment)

@IsraelAraujo70 pr#39595 has already been closed, they didn't even accept it as a preview.
I recommend you contact the staff for more details.
I don't want you to waste time like other developers have.

The git graph is a stretch goal for our current Git project, so I can't promise anything. However, it's something that I want to add, so I'll be willing to put some work in during my free time. With that said, I still need to talk with our designer and team lead to see what direction we would take this in.

@Anthony-Eid : Could we reconsider starting from #39595?

Yeah agree, I think the #39595 is a better starting point.
I'm willing to help so we can have this feature earlier.

@Anthony-Eid : Could we reconsider starting from #39595?

Starting from #39595 is difficult because it has a +11k line diff. Meaning that the Zed team would have to spend a lot of time auditing/reviewing the PR, and commit to maintaining that code once it's merged.

I also need to talk with the team and the design to figure out how we want the git graph to interact with Zed's UI.

With that being said, if I was working on it there are some files I would cherry pick from that PR. I still don't know if I'm going to be the one to work on the git graph btw.

As the author of this PR, I'm not proud of the UI. I could do much better then this. But I'm also new to rust. So if I have a say on this, the other branch seems more like a finished product. Mine is more to fill a hole.

@Anthony-Eid : Could we reconsider starting from #39595?

Starting from #39595 is difficult because it has a +11k line diff. Meaning that the Zed team would have to spend a lot of time auditing/reviewing the PR, and commit to maintaining that code once it's merged.

I also need to talk with the team and the design to figure out how we want the git graph to interact with Zed's UI.

With that being said, if I was working on it there are some files I would cherry pick from that PR. I still don't know if I'm going to be the one to work on the git graph btw.

On the weekend I'll revisit the PR and try to make it better.

@Anthony-Eid : If you carefully analyze pr#39595, there are two large files, one of 4,304 and one of 1,812, of which the 4,304 file looks like a test file.

Could maybe help the designers, but I personally really like the way Bitbucket display graphs (in their latest version of Bitbucket Cloud). That's probably the only thing they do great imo lol

Looks like #44434 supersedes this one hence closing.