Upgrade libsodium to 1.0.18 #4359
Conversation
I'm not adding test vectors for non-canonical pubkeys, as that would require grinding to find a private key corresponding to one of the 19 pubkeys that can be non-canonical.
according to changelogs backwards compatible and containing various optimizations: https://github.com/jedisct1/libsodium/releases https://fossies.org/diffs/libsodium/1.0.15_vs_1.0.16/ChangeLog-diff.html https://fossies.org/diffs/libsodium/1.0.16_vs_1.0.17/ChangeLog-diff.html https://fossies.org/diffs/libsodium/1.0.17_vs_1.0.18/ChangeLog-diff.html (EDIT by str4d): The update is not in fact backwards-compatible; the passing test cases added in the previous commit fail as of this commit.
|
Note to reviewers: the patches to pubkey validation and signature validation are applied separately, because the pubkey validation patch on its own fixes all except one of the test case failures, while the signature validation patch is necessary to resolve the last failure, and proves that the set of valid signatures was altered in libsodium 1.0.16. |
|
ACK. I also ran the tests on |
|
Addressed @daira's comments. |
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
Nit: "validatio" typo in the last commit comment. Otherwise utACK.
|
Once I've updated the spec I'd like someone to check consistency with this PR, but that doesn't need to block merging it. (Needs one more review.) |
Some of the comments in the 1.0.15 code were incorrect.
str4d
force-pushed
the
2872-upgrade-libsodium
branch
from
2906fe3 to
0cca79a
Compare
|
Force-pushed to fix the commit comment. No change to PR. |
defuse
left a comment
defuse
left a comment
There was a problem hiding this comment.
utACK, looked over the old/new libsodium code to make sure the behavior is the same.
|
@zkbot r+ |
|
📌 Commit 0cca79a has been approved by |
|
⌛ Testing commit 0cca79a with merge 48550eab29a6415208881e52196cb53a33d03ed2... |
|
💔 Test failed - pr-merge |
|
Blocked on the new dependency being uploaded to the downloads server. |
|
@zkbot retry |
7 participants
Includes patches that maintain consensus compatibility with libsodium 1.0.15 for Ed25519 pubkey and signature validation.
Replaces #4239. Closes #2872.