Closes #1249 - Least Authority Issue C #3181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitcartel
added
C-cleanup
bitcartel
changed the title
str4d
approved these changes
Apr 17, 2018
Contributor
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
utACK. I checked that this matches the upstream commit.
Contributor
|
@zkbot try |
Contributor
|
⌛ Trying commit 0b6594f with merge 10517df5c68479aed1923d52908aba35ef8d9d4f... |
Contributor
|
☀️ Test successful - pr-try |
daira
approved these changes
Apr 21, 2018
Contributor
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
This isn't my preferred way to do this kind of thing (I prefer explicitly loading bytes and shifting; a good compiler should be able to recognize that idiom and replace with the efficient code for the platform). But it's correct as written here (because the uint*_t types are guaranteed to be two's complement and have no padding bits), so utACK.
Contributor
|
@zkbot r+ |
Contributor
|
📌 Commit 0b6594f has been approved by |
Contributor
zkbot
added a commit
that referenced
this pull request
Apr 21, 2018
Closes #1249 - Least Authority Issue C Backports the first commit from bitcoin/bitcoin#9512 to avoid unaligned access in crypto i/o.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the first commit from bitcoin/bitcoin#9512 to avoid unaligned access in crypto i/o.