Rationalize currency unit to "ZEC" #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously various user-facing strings have used inconsistent currency units "BTC", "btc" and "bitcoins". This adds a single constant and uses it for each reference to the currency unit. Also adds a description of the unit for --maxtxfee, and adds the missing "amount" field description to the (deprecated) move RPC command.
str4d
added
C-cleanup
This was referenced Aug 3, 2017
bitcartel
approved these changes
Sep 11, 2017
arcalinea
suggested changes
Sep 14, 2017
|
|
||
| extern const std::string CURRENCY_UNIT; | ||
|
|
||
| /** No amount larger than this (in satoshi) is valid. |
Contributor
Author
There was a problem hiding this comment.
There are other PRs that handle these changes. This PR solely focuses on the currency unit.
|
|
||
| /** No amount larger than this (in satoshi) is valid. | ||
| * | ||
| * Note that this constant is *not* the total money supply, which in Bitcoin |
arcalinea
approved these changes
Sep 15, 2017
Contributor
|
ACK, let's try to get the other PR's changing the names in there too though. At least before 1 yr is up :) |
Contributor
Author
|
@zkbot r+ |
Contributor
|
📌 Commit 6dec2d0 has been approved by |
zkbot
added a commit
that referenced
this pull request
Sep 18, 2017
Rationalize currency unit to "ZEC" Cherry-picked from the upstream PR bitcoin/bitcoin#6504 Part of #2074
Contributor
Contributor
This was referenced Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from the upstream PR bitcoin/bitcoin#6504
Part of #2074