rpc: Implement random-cookie based authentication #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no `-rpcpassword` is specified, use a special 'cookie' file for authentication. This file is generated with random content when the daemon starts, and deleted when it exits. Read access to this file controls who can access through RPC. By default this file is stored in the data directory but it be overriden with `-rpccookiefile`. This is similar to Tor CookieAuthentication: see https://www.torproject.org/docs/tor-manual.html.en Alternative to zcash#6258. Like that pull, this allows running bitcoind without any manual configuration. However, daemons should ideally never write to their configuration files, so I prefer this solution.
str4d
added
S-waiting-on-review
bitcartel
reviewed
Jan 17, 2017
Contributor
There was a problem hiding this comment.
ACK once the following issue is addressed: option '-server' is by default 1, so with this backport, when simply launching zcashd out of the box, the rpc interface is available.
I think we should change bitcoind.cpp line 145 SoftSetBoolArg("-server", true); to false, and also update the configuration instructions to add 'server=1' to zcash.conf: https://github.com/zcash/zcash/wiki/1.0-User-Guide
Contributor
Author
|
I disagree, for two reasons:
|
Contributor
Contributor
|
@zkbot r+ |
Contributor
|
📌 Commit e957192 has been approved by |
Contributor
zkbot
added a commit
that referenced
this pull request
Jan 18, 2017
rpc: Implement random-cookie based authentication Cherry-picked from bitcoin/bitcoin#6388. Closes #1950.
Contributor
|
☀️ Test successful - zcash |
ondrejsika
added a commit
to ondrejsika/zcash
that referenced
this pull request
Jan 25, 2017
Zcash 1.0.5 This release contains a number of bug fixes and minor usability improvements, including: 1. The chain is now fully rescanned when keys are imported that are older than the wallet. (zcash#1978) 2. The number of commitments in the note commitment tree is now displayed by `getblockchaininfo`. (zcash#1946) 3. `zcash.conf` now must exist in order to start zcashd. (zcash#2013) 4. Fixed a bug where `z_sendmany` logged incorrect txid fragments when sending from transparent addresses. (zcash#1980) 5. We integrated upstream's cookie-based RPC authentication. (zcash#1999) 6. We added a restriction to wallet export paths to protect user security. (zcash#2006) 7. `z_getoperationstatus` is now sorted chronologically. (zcash#2015) 8. Messages containing newlines are now rendered properly by the metrics UI. (zcash#1972) 9. We added more tools for benchmarking JoinSplit creation. (zcash#1953) 10. We now show serialized transaction size in `listtransactions`, more operation details in `z_getoperationstatus`, and the age of the note being spent in `z_sendmany` logging. (zcash#2001, zcash#1976, zcash#1977) 11. We now instruct users to run `fetch-params` if the parameters could not be found locally. (zcash#1979) 12. We handle exceptions better in some situations for more user-friendly error messages. (zcash#1976) For a more complete list of changes, see our [1.0.5 milestone](https://github.com/zcash/zcash/milestone/49?closed=1).
jmprcx
added a commit
to z-classic/zclassic
that referenced
this pull request
Jan 31, 2017
Zcash 1.0.5 This release contains a number of bug fixes and minor usability improvements, including: 1. The chain is now fully rescanned when keys are imported that are older than the wallet. (zcash#1978) 2. The number of commitments in the note commitment tree is now displayed by `getblockchaininfo`. (zcash#1946) 3. `zcash.conf` now must exist in order to start zcashd. (zcash#2013) 4. Fixed a bug where `z_sendmany` logged incorrect txid fragments when sending from transparent addresses. (zcash#1980) 5. We integrated upstream's cookie-based RPC authentication. (zcash#1999) 6. We added a restriction to wallet export paths to protect user security. (zcash#2006) 7. `z_getoperationstatus` is now sorted chronologically. (zcash#2015) 8. Messages containing newlines are now rendered properly by the metrics UI. (zcash#1972) 9. We added more tools for benchmarking JoinSplit creation. (zcash#1953) 10. We now show serialized transaction size in `listtransactions`, more operation details in `z_getoperationstatus`, and the age of the note being spent in `z_sendmany` logging. (zcash#2001, zcash#1976, zcash#1977) 11. We now instruct users to run `fetch-params` if the parameters could not be found locally. (zcash#1979) 12. We handle exceptions better in some situations for more user-friendly error messages. (zcash#1976) For a more complete list of changes, see our [1.0.5 milestone](https://github.com/zcash/zcash/milestone/49?closed=1). Conflicts: README.md configure.ac contrib/debian/changelog contrib/debian/control contrib/debian/manpages/zcash-cli.1 contrib/debian/manpages/zcashd.1 contrib/gitian-descriptors/gitian-linux.yml doc/authors.md src/Makefile.gtest.include src/chainparams.cpp src/clientversion.h src/init.cpp src/main.h src/metrics.cpp src/metrics.h src/util.cpp src/wallet/asyncrpcoperation_sendmany.cpp src/wallet/asyncrpcoperation_sendmany.h src/wallet/rpcwallet.cpp src/zcbenchmarks.cpp zcutil/build-debian-package.sh
This was referenced Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from bitcoin/bitcoin#6388.
Closes #1950.