Skip to content

Instantiate Rust containers from Python - #72

Merged
flying-sheep merged 14 commits into
ld/http_storefrom
pa/classy
Dec 14, 2024
Merged

flying-sheep merged 14 commits into
ld/http_storefrom
pa/classy

Conversation

@flying-sheep

@flying-sheep flying-sheep commented Dec 13, 2024 •

Copy link
Copy Markdown
Collaborator

OK, I think I’m mostly there!

I don’t know where I made an error, could you maybe take a look @LDeakin?

TODO:

  • Maybe we need to improve performance of Basic: It currently contains a StoreConfig, and on each access locks the hashmap. We should probably keep the previous behavior of having Arcs in there which is probably faster

@flying-sheep flying-sheep changed the title Make Raw into class Instantiate Rust containers from Python Dec 13, 2024
@flying-sheep
flying-sheep requested a review from LDeakin December 13, 2024 14:54
@flying-sheep flying-sheep linked an issue Dec 13, 2024 that may be closed by this pull request

@LDeakin LDeakin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Performance seems to be unchanged.

@flying-sheep
flying-sheep merged commit 223c57d into ld/http_store Dec 14, 2024
@flying-sheep
flying-sheep deleted the pa/classy branch December 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't Use Tuples for Crossing The Python-Rust Language Barrier

2 participants