Allow chunk_store argument in open_consolidated() #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Apr 23, 2020
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ajelenak! Can you add a test that passes a separate value for chunk_store to ensure things are working as expected?
Contributor
Author
|
A test was added. |
|
So just one more approval needed? 🤞 |
alimanfoo
reviewed
Apr 28, 2020
Member
alimanfoo
left a comment
alimanfoo
left a comment
There was a problem hiding this comment.
Hiya, this LGTM, just had a small suggestion to simplify.
alimanfoo
approved these changes
Apr 28, 2020
jrbourbeau
approved these changes
Apr 30, 2020
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ajelenak, this is in
Member
|
Also, I noticed this was your first code contribution to this repository. Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR enables using
chunk_storeargument inopen_consolidated(). It also fixes testing in pydata/xarray/pull/3804. No change to documentation required.