Repository navigation
Conversation
Python shows a DeprecationWarning by default only when it is attributed to __main__, so warnings that pointed at zarr internals were hidden from users running scripts: - `ArrayV2Metadata.chunk_grid` is a cached_property, which adds a frame; stacklevel 2 pointed at functools. Now 3. - Setting `zarr.storage.default_compressor` used stacklevel 1, which pointed at zarr itself. Now 2. Tests now assert the warning location. The deprecation policy in docs/contributing.md explains why the location matters, and notes that a warning raised inside a coroutine cannot reach the caller through the synchronous API, so deprecations that must reach script users should warn from the public synchronous function. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4612 +/- ##
==========================================
+ Coverage 94.88% 94.90% +0.02%
==========================================
Files 96 96
Lines 14048 14048
==========================================
+ Hits 13329 13332 +3
+ Misses 719 716 -3
🚀 New features to boost your workflow:
|
d-v-b
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I increased the stacklevel for a couple deprecation warnings because
cached_propertyadds a stack level and we want the warnings to be visible.For reviewers
I'm confident in these changes.
Author attestation
TODO
docs/user-guide/*.mdchanges/