Repository navigation
feat(zarr-metadata)!: replace scope update with copy(update=...) and add definitions with union - #4598
Merged
Conversation
…add definitions with union `ZarrV3Context.update(**slots)` and `ZarrV2Context.update(**slots)` read as a merge, but replace each slot whole, so passing one new definition silently dropped every default. They become `copy(*, update=None)`, after pydantic's `model_copy(update=...)`, whose replace-whole meaning pydantic users already know. Adding definitions is `union`, which keeps every definition the scope has and refuses a conflicting one; the docs, docstrings and call sites now use it instead of splicing a slot's definitions back in. Fixes #424 Assisted-by: ClaudeCode:claude-opus-5-5
…ts PR Assisted-by: ClaudeCode:claude-opus-5-5
Documentation build overview
5 files changed ·
|
…r-9bd090 Main renamed the scopes to *_CONTEXT and fields to declarations, and added scope update call sites (ZARR_PYTHON_CONTEXT, fixed_length_utf32, the vlen codecs). Conflicts take main's side, then rewrite each scope update into union (when it splices a slot's definitions back in) or copy(update=...), and restore this branch's copy/union docs under the new names. Assisted-by: ClaudeCode:claude-opus-5-5
…nd name copy in scope docstrings Assisted-by: ClaudeCode:claude-opus-5-5
d-v-b
marked this pull request as ready for review
November 4, 2026 10:15
This was referenced Nov 8, 2026
d-v-b
added a commit
that referenced
this pull request
Nov 11, 2026
…the #4598 fragment (#4617) Replace the ten bugfix fragments of #4574 with three, two of them marked breaking, and shorten the #4592 fragment to the rename and the names a user is most likely to have imported. The removed detail stays in the pull requests. Rename 427.removal.md to 4598.removal.md: the fragment came in with #4598 but carried the fork PR's number, so the changelog would have linked to an unrelated upstream PR. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changes the API for copying / merging contexts to ensure that consumers know which methods blend fields vs which methods overwrite
Author attestation
TODO
docs/user-guide/*.mdchanges/