Repository navigation
Conversation
Based on external implementation at https://github.com/clbarnes/zarr-python-reshape .
github-actions
Bot
added
the
needs release notes
github-actions
Bot
removed
the
needs release notes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4542 +/- ##
==========================================
+ Coverage 94.90% 94.91% +0.01%
==========================================
Files 96 97 +1
Lines 14051 14140 +89
==========================================
+ Hits 13335 13421 +86
- Misses 716 719 +3
🚀 New features to boost your workflow:
|
d-v-b
reviewed
Nov 2, 2026
| chunk_grid: ChunkGridMetadata, | ||
| ) -> None: | ||
| """Validate the codec configuration against the array metadata.""" | ||
| self._compute_output_shape(shape) |
Contributor
There was a problem hiding this comment.
we have to validate against the chunk shape, not the array shape
Contributor
There was a problem hiding this comment.
there's a bigger fix we need in this are that also affects sharding and transpose, see #4352. i'll try to get that merged
Contributor
Author
There was a problem hiding this comment.
Ah, I suppose that's not accessible here then - it's called against the array, not the chunk. No validation to be done here, then, as validating the shape spec is done on instantiation.
Previously, the codec would try to validate itself using the array shape, rather than the chunk shape.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4541 .
Implements the reshape extension codec.
This codec was recommended for inclusion in mainline zarr-python because it will be built on top of by other codecs (e.g. most image codecs).
Author attestation
TODO
docs/user-guide/*.mdchanges/